313728 - Re-fix accesskeys on show bug page to not clash with browser

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Gervase Markham [:gerv]]

I mistakenly checked in some duff code in bug 215148 which regressed part of bug 163007. This bug covers backing that out on branch and trunk.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This patch removes the four accidentally-added accesskeys. It applies to the trunk directly, and to the branch with a 13-line offset. Please review and approve for checkin on both.

Gerv

Comment 2

[:Gavin Sharp [email: [e-mail]]]

See bug 313454, you probably want to post your patch there?

Comment 3

[Gervase Markham [:gerv]]

*** Bug 313454 has been marked as a duplicate of this bug. ***

Comment 4

[Marc Schumann [:Wurblzap]]

Comment on attachment 200722 [details] [diff] [review]
Patch v.1

You should remove the access key underlinings, too (S<u>e</u>verity et al), too.

Comment 5

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Oops. Here's version 2.

Gerv

Comment 6

[Frédéric Buclin]

Comment on attachment 205947 [details] [diff] [review]
Patch v.2

r=LpSolit for tip and 2.20.

Comment 7

[Frédéric Buclin]

tip:

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.66; previous revision: 1.65
done

2.20:

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.60.2.2; previous revision: 1.60.2.1
done

Comment 8

[Simon Bünzli]

*** Bug 334103 has been marked as a duplicate of this bug. ***