313888 - Empty URL should not be auto-completed

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P4)

Description

[Ng Ming Hong]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1

Currently the URL can be auto-completed even if nothing is entered, hence resulting in URLs like http://www..com, http://www..net, and http://www..org

As empty URL is not visited (i.e. try pressing Enter in an empty location bar), empty URL should not be auto-completed as well.

Reproducible: Always

Steps to Reproduce:
1. Empty the location bar (e.g. by opening a new blank window/tab)
2. Press Ctrl + Enter, Shift + Enter or Ctrl + Shift + Enter

Actual Results:  
Firefox auto-completes the empty URL and visit the non-existent URLs http://www..com, http://www..net, and http://www..org respectively.

Expected Results:  
Stay on the current page.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Yeah, this is weird, but why should one do that? 

Comment 2

[u63580]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051024 Firefox/1.5

See that here to.  Clearly rather odd and I can't find a dupe.  It's only minor, I agree, but I think this is a bug.

Comment 3

[Ng Ming Hong]

(In reply to comment #1)
> Yeah, this is weird, but why should one do that? 
> 

Because I accidentally pressed the keyboard shortcut for auto-complete before entering the domain name. :-P

P.S. IE has the same behavior, but Firefox should be better, right?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 201216 [details] [diff] [review]
patch

This is silly, but might as well.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js; new revision: 1.543;

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 201216 [details] [diff] [review]
patch

trivial fix

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Checked in on the 1.8 branch for Firefox 2.
mozilla/browser/base/content/browser.js; new revision: 1.479.2.51;

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?id=4519

in-litmus+

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a9pre) Gecko/2007102704 Minefield/3.0a9pre

and

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007102721 Minefield/3.0a9pre