313894 - Reporter chrome is registered twice

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P1)

Description

[Pavel Franc - Mozilla.cz]

The resource for reporter locale is registered twice. Once in installed-chrome.txt and next time in ab-CD.manifest.

Comment 1

[Benjamin Smedberg]

Regression from bug 312510, this will negatively affect mac builds and could cause significant pain in the future due to bad leftover registrations.

Comment 2

[Benjamin Smedberg]

This is not locale-specific, all the reporter chrome is being registered twice.

Comment 3

[Benjamin Smedberg]

Attachment: Don't autoreg in reporter

Comment 4

[Scott MacGregor]

Can you be more specific about the level of pain and the negative ramifications? 1.5 is currently done and we'd have to have a good reason/justification to decide to respin and slip the release schedule by a day to pick this up. 

Comment 5

[Benjamin Smedberg]

What will happen is that we'll ship an installed-chrome.txt file: this basically permanently registers the reporter chrome in a particular location. If we ever decide to move reporter we're going to have old registration information which is likely to cause XUL errors. Since installed-chrome.txt can be modified at runtime (by xpinstall), this also means that partial patching will fail in some cases, and that xpinstalled chrome (not extensions, but install.js-style xpis) will become unregistered on every upgrade with a full MAR.

If we're doing another RC I'd say this can wait for the next one, but we can't ship 1.5final like this.

This does not affect tbird.

Comment 6

[Scott MacGregor]

From your summary, there's no downstream code path we can pursue which will fix this after the fact? i.e. we can't fix installed-chrome.txt via the update mechanism at a later date because installed-chrome.txt gets modified run time.

Is this issue only a problem if we only decide to move the reporter tool to a new location? If a future release does something like that can we work around this at that time by removing the old reporter files via the removed files package list in the update? I guess that wouldn't unregister the chrome package though from installed-chrome.txt.

Comment 7

[Benjamin Smedberg]

> Is this issue only a problem if we only decide to move the reporter tool to a
> new location? If a future release does something like that can we work around
> this at that time by removing the old reporter files via the removed files
> package list in the update? I guess that wouldn't unregister the chrome package
> though from installed-chrome.txt.

Right, removing the files doesn't fix the problem, because the chrome registry doesn't know whether the files are there or not, it only knows what the registration lines have told it.

Comment 8

[Asa Dotzler [:asa]]

not going to lose a day with this but could become a ride-along if we're forced to respin by some other bug.

Comment 9

[Benjamin Smedberg]

Fixed on trunk.

Comment 10

[Asa Dotzler [:asa]]

not going to lose a day with this but could become a ride-along if we're forced to respin by some other bug.

Comment 11

[Asa Dotzler [:asa]]

moving out to the 1.8 rc2 ride-along candidate list. We'll consider taking this if we do an RC2.

Comment 12

[Benjamin Smedberg]

Fixed on 1.8 branch.