The default bug view has changed. See this FAQ.

IME candidate list is positioned to wrong position if the caret is positioned non-root view

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
Event Handling
RESOLVED FIXED
12 years ago
7 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

(4 keywords)

Trunk
mozilla1.9alpha1
x86
Windows 2000
inputmethod, intl, jp-critical, verified1.8.1.10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Assignee)

Description

12 years ago
If the editor is positioned non-root view(e.g., the option dialog of Firefox/Thunderbird and the Edit Card dialog of Address Book), the IME candidate list window is positioned wrong position.
(Assignee)

Comment 1

12 years ago
Created attachment 200893 [details] [diff] [review]
Patch rv1.0

We need to test this patch on non Windows OS.
(Assignee)

Comment 2

12 years ago
Created attachment 200895 [details]
screenshot of current build
(Assignee)

Comment 3

12 years ago
Created attachment 200897 [details]
screenshot of patched windows build
(Assignee)

Comment 4

12 years ago
Bezilla staff:

This patch is changing the XP IME event's reply values.
Could you test this patch on BeOS?
Status: NEW → ASSIGNED
(Assignee)

Comment 5

12 years ago
Created attachment 200898 [details] [diff] [review]
Patch rv1.1

Oops... Sorry. Previous patch is not enough.
Attachment #200893 - Attachment is obsolete: true

Comment 6

12 years ago
I couldnt' reproduce this bug at BeOS, with native IME dialog btw.
May test those changes when new build is finished, but most probably at coming weekend
(Assignee)

Comment 7

12 years ago
Comment on attachment 200898 [details] [diff] [review]
Patch rv1.1

Ah... This patch is wrong. I'll create new patch.
Attachment #200898 - Attachment is obsolete: true
Attachment #200898 - Flags: review-
(Assignee)

Comment 8

12 years ago
Created attachment 201116 [details] [diff] [review]
Patch rv2.0

This patch is "adhoc".
But we select this way in bug 59405. Because, if we select the best way, we need very large change for this bugs. But this adhoc way makes very small change for us.
Attachment #201116 - Flags: superreview?(roc)
Attachment #201116 - Flags: review?(roc)
(Assignee)

Updated

12 years ago
Depends on: 59405
(Assignee)

Comment 9

12 years ago
Bezilla staff:

The new patch changes only Windows code.
Thanks.
Attachment #201116 - Flags: superreview?(roc)
Attachment #201116 - Flags: superreview+
Attachment #201116 - Flags: review?(roc)
Attachment #201116 - Flags: review+
(Assignee)

Comment 10

12 years ago
checked-in.

Thank you roc!
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Depends on: 315457
(Assignee)

Comment 11

10 years ago
Momoi-san(Google) reported that this bug can be reproduced with new chat form on Gmail. And I confirmed it, and the patch for this bug and bug 315457 can fix the bug. We should land the patches to 1.8 branch.
(Assignee)

Comment 12

10 years ago
Created attachment 287316 [details] [diff] [review]
Patch for 1.8 branch (attachment 201116 [details] [diff] [review] and attachment 202190 [details] [diff] [review])

This patch is merged the patch for this bug (attachment 201116 [details] [diff] [review]) and the patch for bug 315457 which is regression of this bug (attachment 202190 [details] [diff] [review]). The patches are already working fine on trunk during a long term. r+sr are carried over from the original patches, this patch is not changed anything from them.
Attachment #287316 - Flags: superreview+
Attachment #287316 - Flags: review+
Attachment #287316 - Flags: approval1.8.1.10?
(Assignee)

Updated

10 years ago
Flags: blocking1.8.1.10?
Whiteboard: we can reproduce this bug with the chat form of Gmail with Fx2
(Assignee)

Updated

10 years ago
Keywords: jp-critical

Comment 13

10 years ago
Thanks Nakano-san for proposing to down integrate the fix into the 1.8 branch. 

Google products have a fairly large number of Firefox 2 users. This bug severely affects Chinese and Japanese users of the following products:

1. Gmail (new UI) that went out last week to some users and will be going to all Gmail users shortly.

* Non-detached chat window at bottom right
* Address Book - Name input field for a new entry

2. Google Spreadsheet: current version at docs.google.com

* All cell input 

3. Google Presentation: current version at docs.google.com

* Link text input window

There are likely to be other products with the same problem -- wherever there is a non-root window.

Please get this in asap for the IME users in these countries. Thanks!
Comment on attachment 287316 [details] [diff] [review]
Patch for 1.8 branch (attachment 201116 [details] [diff] [review] and attachment 202190 [details] [diff] [review])

approved for 1.8.1.10, a=dveditz for release-drivers
Attachment #287316 - Flags: approval1.8.1.10? → approval1.8.1.10+
(Assignee)

Comment 15

10 years ago
checked-in.
Flags: blocking1.8.1.11?
Keywords: fixed1.8.1.10
Whiteboard: we can reproduce this bug with the chat form of Gmail with Fx2
Masayuki, can you check with the Firefox 2.0.0.10 release candidate at http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2.0.0.10-candidates/rc1/ and verify that this is fixed?
(Assignee)

Comment 17

10 years ago
-> v. on 1.8.1.10
Keywords: fixed1.8.1.10 → verified1.8.1.10
(Assignee)

Updated

7 years ago
Keywords: inputmethod
You need to log in before you can comment on or make changes to this bug.