313962 - Simple bug in GConf nsSystemPrefs

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

nsSystemPrefs, which synchronizes certain preferences with GConf, has a bug that causes it to crash in certain embedding situations. Actually it's a general bug with using uninitialized memory that happens to always work in regular Firefox builds.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Later on it does
        if (aPrefValue->stringVal)
            PL_strfree(aPrefValue->stringVal);
which dies horribly if there happens to be something non-zero in the new array.

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

Once this is reviewed and considered to be safe enough this should go to 1.8.1 and 1.8.0.1 (especially for xulrunner).

Comment 3

[Benjamin Smedberg]

Not blocking, though we might accept this on the 1.8.0 branch at some point if it were reviewed and smoketested on the trunk.

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 200946 [details] [diff] [review]
fix

I don't know for sure who the owner of the code is but since there is almost only gconf code which is related to GTK I've chosen the GTK owner for 1.8.1 approval.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 200946 [details] [diff] [review]
fix

Even though it's my own patch, I'm approving it because it's trivial.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fixed on trunk and branch. I'm not going for 1.8.0.x approval because the vendors who actually use this code can patch it themselves.