Closed Bug 314015 Opened 19 years ago Closed 19 years ago

nsComponentManagerUtils.h uses wrong linking macro, SDK 1.8 is broken

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

(Keywords: fixed1.8)

Attachments

(1 file)

Fix usage
3.55 KB, patch
darin.moz
: review+
asa
: approval1.8rc2+
Details | Diff | Splinter Review 
nsComponentManagerUtils.h uses NS_COM in places where it should use NS_COM_GLUE, meaning that usage of do_CreateInstanceByContractID is broken for the 1.8 SDK.
Attached patch Fix usage — — Splinter Review 

        Attachment #200983 -
        Flags: review?(darin)

    
  
Flags: blocking1.8rc1?

    
    

    
  
Comment on attachment 200983 [details] [diff] [review]
Fix usage

wow, that's very unfortunate.  the ff 1.5 train has already nearly left the station too :(

        Attachment #200983 -
        Flags: review?(darin) → review+

    
  

        Attachment #200983 -
        Flags: approval1.8rc1?

    
    

    
  
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

    
    

    
  
This bug makes me wonder if we shouldn't have a separate release branch for the GECKO_1_8_SDK.

    
    

    
  
Let's not go down the private-branch road yet, I'm pretty sure this can land before RC2.

    
    

    
  
What RC2? ;-)

    
    

    
  
with this change, rdf/tests/triplescat fails to compile (see Brad tbox):

/usr/bin/ld: triplescat.o(.text+0x203): unresolvable R_386_GOTOFF relocation against symbol `vtable for nsCreateInstanceByContractID'
/usr/bin/ld: final link failed: Nonrepresentable section on output

    
    

    
  
triplescat did not have MOZILLA_INTERNAL_API, now fixed r=Pike

Fix verified by original reporter on npm.xpcom
Status: RESOLVED → VERIFIED

    
    

    
  
i think i filed a bug about this elsewhere, could someone find it? :(

    
    

    
  
moving out to the 1.8 rc2 ride-along candidate list. We'll consider taking this if we do an RC2.
Flags: blocking1.8rc1? → blocking1.8rc2?

    
  

        Attachment #200983 -
        Flags: approval1.8rc1? → approval1.8rc2+

    
    

    
  
Fixed on 1.8 branch.
Flags: blocking1.8rc2? → blocking1.8rc2+
Keywords: fixed1.8

    
    

    
  
*** Bug 292259 has been marked as a duplicate of this bug. ***

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: