nsComponentManagerUtils.h uses wrong linking macro, SDK 1.8 is broken

VERIFIED FIXED

Status

()

Core
XPCOM
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: bsmedberg, Assigned: bsmedberg)

Tracking

({fixed1.8})

Trunk
fixed1.8
Points:
---
Bug Flags:
blocking1.8rc2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
nsComponentManagerUtils.h uses NS_COM in places where it should use NS_COM_GLUE, meaning that usage of do_CreateInstanceByContractID is broken for the 1.8 SDK.
(Assignee)

Comment 1

12 years ago
Created attachment 200983 [details] [diff] [review]
Fix usage
Attachment #200983 - Flags: review?(darin)
(Assignee)

Updated

12 years ago
Flags: blocking1.8rc1?

Comment 2

12 years ago
Comment on attachment 200983 [details] [diff] [review]
Fix usage

wow, that's very unfortunate.  the ff 1.5 train has already nearly left the station too :(
Attachment #200983 - Flags: review?(darin) → review+
(Assignee)

Updated

12 years ago
Attachment #200983 - Flags: approval1.8rc1?
(Assignee)

Comment 3

12 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 4

12 years ago
This bug makes me wonder if we shouldn't have a separate release branch for the GECKO_1_8_SDK.
(Assignee)

Comment 5

12 years ago
Let's not go down the private-branch road yet, I'm pretty sure this can land before RC2.

Comment 6

12 years ago
What RC2? ;-)

Comment 7

12 years ago
with this change, rdf/tests/triplescat fails to compile (see Brad tbox):

/usr/bin/ld: triplescat.o(.text+0x203): unresolvable R_386_GOTOFF relocation against symbol `vtable for nsCreateInstanceByContractID'
/usr/bin/ld: final link failed: Nonrepresentable section on output
(Assignee)

Comment 8

12 years ago
triplescat did not have MOZILLA_INTERNAL_API, now fixed r=Pike

Fix verified by original reporter on npm.xpcom
Status: RESOLVED → VERIFIED

Comment 9

12 years ago
i think i filed a bug about this elsewhere, could someone find it? :(
timeless: bug 292259 perhaps?

Comment 11

12 years ago
moving out to the 1.8 rc2 ride-along candidate list. We'll consider taking this if we do an RC2.
Flags: blocking1.8rc1? → blocking1.8rc2?

Updated

12 years ago
Attachment #200983 - Flags: approval1.8rc1? → approval1.8rc2+
(Assignee)

Comment 12

12 years ago
Fixed on 1.8 branch.
Flags: blocking1.8rc2? → blocking1.8rc2+
Keywords: fixed1.8
*** Bug 292259 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.