select(1) fails to bind item labels correctly

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
12 years ago
10 months ago

People

(Reporter: aaronr, Assigned: Doron Rosenberg (IBM))

Tracking

({fixed1.8.0.2, fixed1.8.1})

Trunk
x86
Windows XP
fixed1.8.0.2, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
I noticed that after I wrote this testcase for select and select1 that the labels didn't show up and that it gave off warnings in nsXFormsUtils::GetNodeValue.  It looks like that instead of the labels binding to the description node, they bind to the document and are returning a nodeType of nsIDOMNode::DOCUMENT_NODE which we don't expect.

Testcase coming.
(Reporter)

Comment 1

12 years ago
Created attachment 201106 [details]
testcase

Should see a select1 with Vanilla, Strawberry and Chocolate as items.
(Assignee)

Comment 2

12 years ago
Created attachment 201548 [details]
better testcase - both itemset/repeat are affected
Assignee: aaronr → doronr
Attachment #201106 - Attachment is obsolete: true
Status: NEW → ASSIGNED
(Assignee)

Comment 3

12 years ago
Created attachment 201549 [details] [diff] [review]
fix itemset/repeat

Issue is simple - itemset/repeat were passing in a domElement to ->SetContext.  However, a attribute node is not a dom element, and thus the QI from dom node to dom element failed.
Attachment #201549 - Flags: review?(smaug)

Updated

12 years ago
Attachment #201549 - Flags: review?(smaug) → review+
(Assignee)

Updated

12 years ago
Attachment #201549 - Flags: review?(aaronr)
(Reporter)

Updated

12 years ago
Attachment #201549 - Flags: review?(aaronr) → review+
(Assignee)

Comment 4

12 years ago
checked into trunk
Whiteboard: xf-to-branch
(Reporter)

Comment 5

11 years ago
checked into MOZILLA_1_8_BRANCH via bug 323691.  Leaving open for now until it gets into 1.8.0

Updated

11 years ago
Whiteboard: xf-to-branch

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.0.2
Resolution: --- → FIXED
(Reporter)

Comment 6

11 years ago
verfied fixed on MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.