Closed Bug 314158 Opened 19 years ago Closed 19 years ago

select(1) fails to bind item labels correctly

Categories

(Core Graveyard :: XForms, defect)

Product:
Core Graveyard
Component:
XForms
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: aaronr, Assigned: doronr)

Details

(Keywords: fixed1.8.0.2, fixed1.8.1)

Attachments

(2 files, 1 obsolete file)

better testcase - both itemset/repeat are affected
2.20 KB, application/xhtml+xml
Details
fix itemset/repeat
2.85 KB, patch
smaug
: review+
aaronr
: review+
Details | Diff | Splinter Review 
I noticed that after I wrote this testcase for select and select1 that the labels didn't show up and that it gave off warnings in nsXFormsUtils::GetNodeValue.  It looks like that instead of the labels binding to the description node, they bind to the document and are returning a nodeType of nsIDOMNode::DOCUMENT_NODE which we don't expect.

Testcase coming.
Attached file testcase (obsolete) — 
Should see a select1 with Vanilla, Strawberry and Chocolate as items.
Assignee: aaronr → doronr

        Attachment #201106 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

    
    

    
  


  
Issue is simple - itemset/repeat were passing in a domElement to ->SetContext.  However, a attribute node is not a dom element, and thus the QI from dom node to dom element failed.

        Attachment #201549 -
        Flags: review?(smaug)

        Attachment #201549 -
        Flags: review?(smaug) → review+

    
  

        Attachment #201549 -
        Flags: review?(aaronr)

    
  

        Attachment #201549 -
        Flags: review?(aaronr) → review+

    
    

    
  
checked into trunk
Whiteboard: xf-to-branch

    
    

    
  
checked into MOZILLA_1_8_BRANCH via bug 323691.  Leaving open for now until it gets into 1.8.0

    
  
Whiteboard: xf-to-branch

    
  
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.0.2
Resolution: --- → FIXED

    
    

    
  
verfied fixed on MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: