314273 - Various implementations of part and leave break when used with channels with the same name

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[:Gijs (he/him)]

1. /leave is broken in general when there's two channels with the same unicodename (possible w/ different charsets and possibly different servers [UNTESTED/THOUGHT ABOUT]). Need to check if e.hasOwnProperty("channelName"). Need to fix join to do the same instead of __proto__ magic.

2. After that fix, /part is still broken because the command manager clones our event object without taking care of the __proto__ chain, which messes up the hasOwnProperty call. Fix that by making clone work correctly with __proto__ stuff. 

3. After that fix, Tabclick > Leave #channel is still broken, because getTabContext doesn't use __proto__ like getUserListContext and associates, and breaks our __proto__ chain still. Fix that by mimicking the other implementations.

Bug assigned to Silver as per discussion on IRC.

Comment 1

[James Ross]

Attachment: Fix /leave and /part, and tab context generation

This makes a few interesting changes:
  - Clone now only clones direct properties + __proto__ on Spidermonkey.
  - getTabContext now sets up cx.__proto__ as per other get*Context functions.
  - cmdLeave, cmdNames and cmdJoin make use of hasOwnProperty to check for
    user-provided data without messing with __proto__ directly.
  - Some dead code in cmdJoin is removed.

This, altogether, fixes the issue of /leave and /part not behaving sensibly if you join two channels with the same Unicode name (but different charsets).

Comment 2

[James Ross]

Checked in --> FIXED.