314345 - Events and tasks still seen if all calendars is deselected

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Robin Edrenius]

If you deselect all calendars you will still see the events in the event-list and the tasks in the tasks list. You will not see them in the calendar though.

If there are more than one calendar, the events and tasks of the calendar that is deselected last is still shown.

Comment 1

[Joey Minta]

Attachment: handle no calendar case

If there are no calendars, cmpListener never gets a chance to call onOperationComplete, because it never executes a getItems call itself.  Therefore, in this case, we just call onOperationComplete directly.

This is a fairly noticable regression from 0.2.  Not sure if it's bad enough to warrant a last-minute checkin like this though.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 201283 [details] [diff] [review]
handle no calendar case

>     getItems: function (aItemFilter, aCount, aRangeStart, aRangeEnd, aListener) {
>+        // If there are no calendars, then we just call onOperationComplete
>+        if (this.mCalendars.length == 0) {
>+            aListener.onOperationComplete (this,
>+                                           1,
>+                                           calIOperationListener.GET,
>+                                           null,
>+                                           null);

the '1' is pretty magic. Shouldn't it be an nsresult (NS_OK or something)?

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 201283 [details] [diff] [review]
handle no calendar case

see comment 2

Comment 4

[Joey Minta]

Attachment: handle no calendar case v2

Same as before, but without the magic 1.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 202092 [details] [diff] [review]
handle no calendar case v2

r=mvl

Comment 6

[Joey Minta]

patch checked in