314374 - Delete... is enabled in certificates dialog when nothing is selected

Status: RESOLVED FIXED

(Camino Graveyard :: Security, defect)

Description

[timeless]

build id: 2005102908 (v1.0+)

steps:
1. cmd-, (or camino>preferences)
2. click the security widget
3. click show certificates
(nothing should be selected in the right pane)
4. click the strange widget w/ the drop arrow
5. click delete...

expected result:
delete isn't enabled if nothing is selected

actual results:
delete... is enabled and doesn't do anything when clicked

Comment 1

[Simon Fraser [no longer active]]

Patch:
Index: CertificatesWindowController.mm
===================================================================
RCS file: /cvsroot/mozilla/camino/src/security/CertificatesWindowController.mm,v
retrieving revision 1.3
diff -u -r1.3 CertificatesWindowController.mm
--- CertificatesWindowController.mm	8 Sep 2005 16:17:08 -0000	1.3
+++ CertificatesWindowController.mm	30 Oct 2005 18:44:57 -0000
@@ -757,7 +757,7 @@
 {
   SEL action = [inMenuItem action];
   if ((action == @selector(viewSelectedCertificates:)) ||
-      (action == @selector(deleteSelectedCertificate:)))
+      (action == @selector(deleteSelectedCertificates:)))
   {
     return ([[self selectedCertificates] count] > 0);
   }

Comment 2

[Simon Fraser [no longer active]]

Fixed on trunk and branch.