314568 - [FIX]xlink:href attributes are ignored in SVG elements

Status: RESOLVED FIXED

(Core :: SVG, defect, P1)

Description

[Scooter Morris]

This is a recent regression where xlink:href attributes are being ignored by the SVG code base.  This breaks gradients, patterns, and use elements.

Comment 1

[Scooter Morris]

Attachment: Testcase -- should see a gradient

Comment 2

[Boris Zbarsky [:bzbarsky]]

The problem is that SVG needs to see namespaced attrs in ParseAttribute.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Same as diff -w

This fixes the testcase and all

Comment 5

[Hixie (not reading bugmail)]

*** Bug 316236 has been marked as a duplicate of this bug. ***

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 201485 [details] [diff] [review]
Same as diff -w

>Index: content/html/content/src/nsHTMLFrameElement.cpp
>+nsHTMLFrameElement::ParseAttribute(PRInt32 aNamespaceID,
>+                                   nsIAtom* aAttribute,
>                                    const nsAString& aValue,
>                                    nsAttrValue& aResult)
> {
>+  if (aNamespaceID == kNameSpaceID_None) {
>   if (aAttribute == nsHTMLAtoms::bordercolor) {
>-    return aResult.ParseColor(aValue, nsGenericHTMLFrameElement::GetOwnerDoc());
>+      return aResult.ParseColor(aValue,
>+                                nsGenericHTMLFrameElement::GetOwnerDoc());

Just remove 'nsGenericHTMLFrameElement::'

r=me

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 201485 [details] [diff] [review]
Same as diff -w

sr=jst

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated to tip

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 10

[Marco Perez [:mpk]]

Boris, may your checkin have caused bug #318856?

Comment 11

[Marco Perez [:mpk]]

Attachment: suggested patch to fix a regression (see bug #318856)

It does indeed look as if that checkin caused the regression as per bug #318856.
Should my patch get r and sr, can somebody please check it in? I don't have cvs
write access.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 204879 [details] [diff] [review]
suggested patch to fix a regression (see bug #318856)

r+sr=bzbarsky, though it's really better to attach the patch to the bug you're actually fixing... ;)

Comment 13

[Boris Zbarsky [:bzbarsky]]

I checked in that patch.