Closed Bug 314568 Opened 19 years ago Closed 19 years ago

[FIX]xlink:href attributes are ignored in SVG elements

Categories

(Core :: SVG, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: scootermorris, Assigned: bzbarsky)

References

Details

(Keywords: regression)

Attachments

(3 files, 2 obsolete files)

This is a recent regression where xlink:href attributes are being ignored by the SVG code base.  This breaks gradients, patterns, and use elements.
The problem is that SVG needs to see namespaced attrs in ParseAttribute.
Assignee: general → bzbarsky
Blocks: 308270
Priority: -- → P1
Target Milestone: --- → mozilla1.9alpha
Attached patch Fix (obsolete) — Splinter Review
Attached patch Same as diff -w (obsolete) — Splinter Review
This fixes the testcase and all
Attachment #201485 - Flags: superreview?(jst)
Attachment #201485 - Flags: review?(bugmail)
Summary: xlink:href attributes are ignored in SVG elements → [FIX]xlink:href attributes are ignored in SVG elements
*** Bug 316236 has been marked as a duplicate of this bug. ***
Blocks: 317628
Blocks: 317709
Comment on attachment 201485 [details] [diff] [review]
Same as diff -w

>Index: content/html/content/src/nsHTMLFrameElement.cpp
>+nsHTMLFrameElement::ParseAttribute(PRInt32 aNamespaceID,
>+                                   nsIAtom* aAttribute,
>                                    const nsAString& aValue,
>                                    nsAttrValue& aResult)
> {
>+  if (aNamespaceID == kNameSpaceID_None) {
>   if (aAttribute == nsHTMLAtoms::bordercolor) {
>-    return aResult.ParseColor(aValue, nsGenericHTMLFrameElement::GetOwnerDoc());
>+      return aResult.ParseColor(aValue,
>+                                nsGenericHTMLFrameElement::GetOwnerDoc());

Just remove 'nsGenericHTMLFrameElement::'

r=me
Attachment #201485 - Flags: review?(bugmail) → review+
Comment on attachment 201485 [details] [diff] [review]
Same as diff -w

sr=jst
Attachment #201485 - Flags: superreview?(jst) → superreview+
Attached patch Updated to tipSplinter Review
Attachment #201484 - Attachment is obsolete: true
Attachment #201485 - Attachment is obsolete: true
Fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Boris, may your checkin have caused bug #318856?
It does indeed look as if that checkin caused the regression as per bug #318856.
Should my patch get r and sr, can somebody please check it in? I don't have cvs
write access.
Attachment #204879 - Flags: superreview?(jst)
Attachment #204879 - Flags: review?(bugmail)
Comment on attachment 204879 [details] [diff] [review]
suggested patch to fix a regression (see bug #318856)

r+sr=bzbarsky, though it's really better to attach the patch to the bug you're actually fixing... ;)
Attachment #204879 - Flags: superreview?(jst)
Attachment #204879 - Flags: superreview+
Attachment #204879 - Flags: review?(bugmail)
Attachment #204879 - Flags: review+
I checked in that patch.
Depends on: 318856
You need to log in before you can comment on or make changes to this bug.