Closed
Bug 314568
Opened 19 years ago
Closed 19 years ago
[FIX]xlink:href attributes are ignored in SVG elements
Categories
(Core :: SVG, defect, P1)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: scootermorris, Assigned: bzbarsky)
References
Details
(Keywords: regression)
Attachments
(3 files, 2 obsolete files)
1.24 KB,
image/svg+xml
|
Details | |
116.43 KB,
patch
|
Details | Diff | Splinter Review | |
779 bytes,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
This is a recent regression where xlink:href attributes are being ignored by the SVG code base. This breaks gradients, patterns, and use elements.
Reporter | ||
Comment 1•19 years ago
|
||
Assignee | ||
Comment 2•19 years ago
|
||
The problem is that SVG needs to see namespaced attrs in ParseAttribute.
Assignee | ||
Comment 3•19 years ago
|
||
Assignee | ||
Comment 4•19 years ago
|
||
This fixes the testcase and all
Attachment #201485 -
Flags: superreview?(jst)
Attachment #201485 -
Flags: review?(bugmail)
Assignee | ||
Updated•19 years ago
|
Summary: xlink:href attributes are ignored in SVG elements → [FIX]xlink:href attributes are ignored in SVG elements
Comment 5•19 years ago
|
||
*** Bug 316236 has been marked as a duplicate of this bug. ***
Comment on attachment 201485 [details] [diff] [review] Same as diff -w >Index: content/html/content/src/nsHTMLFrameElement.cpp >+nsHTMLFrameElement::ParseAttribute(PRInt32 aNamespaceID, >+ nsIAtom* aAttribute, > const nsAString& aValue, > nsAttrValue& aResult) > { >+ if (aNamespaceID == kNameSpaceID_None) { > if (aAttribute == nsHTMLAtoms::bordercolor) { >- return aResult.ParseColor(aValue, nsGenericHTMLFrameElement::GetOwnerDoc()); >+ return aResult.ParseColor(aValue, >+ nsGenericHTMLFrameElement::GetOwnerDoc()); Just remove 'nsGenericHTMLFrameElement::' r=me
Attachment #201485 -
Flags: review?(bugmail) → review+
Comment 7•19 years ago
|
||
Comment on attachment 201485 [details] [diff] [review] Same as diff -w sr=jst
Attachment #201485 -
Flags: superreview?(jst) → superreview+
Assignee | ||
Comment 8•19 years ago
|
||
Attachment #201484 -
Attachment is obsolete: true
Attachment #201485 -
Attachment is obsolete: true
Assignee | ||
Comment 9•19 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 10•19 years ago
|
||
Boris, may your checkin have caused bug #318856?
Comment 11•19 years ago
|
||
It does indeed look as if that checkin caused the regression as per bug #318856. Should my patch get r and sr, can somebody please check it in? I don't have cvs write access.
Attachment #204879 -
Flags: superreview?(jst)
Attachment #204879 -
Flags: review?(bugmail)
Assignee | ||
Comment 12•19 years ago
|
||
Comment on attachment 204879 [details] [diff] [review] suggested patch to fix a regression (see bug #318856) r+sr=bzbarsky, though it's really better to attach the patch to the bug you're actually fixing... ;)
Attachment #204879 -
Flags: superreview?(jst)
Attachment #204879 -
Flags: superreview+
Attachment #204879 -
Flags: review?(bugmail)
Attachment #204879 -
Flags: review+
Assignee | ||
Comment 13•19 years ago
|
||
I checked in that patch.
You need to log in
before you can comment on or make changes to this bug.
Description
•