314637 - Search Messages can't find some words in ISO-2022-JP messages

Status: VERIFIED FIXED

(MailNews Core :: Search, defect)

Description

[Masatoshi Kimura [:emk]]

Please see this bug using UTF-8 encoding.

Reproducable: Always

Steps to reproduce:
1. Compose new message.
2. Options-Character-Encoding-"Japanese (ISO-2022-JP)".
3. Type "現況".
4. Save it in the Drafts folder.
5. Edit-Find-"Search Messages".
6. Search using the following condition: Body contains "現況".

Actual result:
No matches found.

Expected result.
Match found.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Patch rv1.0

Japanese word "現況" contains the bit pattern "=67" which is misidentified as quoted printable.
Also changed Bugscape ID which is no longer useful.

Comment 2

[Jungshik Shin]

Comment on attachment 201537 [details] [diff] [review]
Patch rv1.0

r=jshin
Please, use 'stateful charsets like ISO-2022-JP' in place of 'stateful csids like JIS'

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Patch rv1.1

Carrying over r+sr (comment only change)

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in to trunk. Thanks, Kimura-san!

Comment 5

[WADA:World Anti-bad-Duping Agency]

VERIFIED with Seamonkey 200511031-trunk/Win-2K.

Comment 6

[Masatoshi Kimura [:emk]]

Comment on attachment 201732 [details] [diff] [review]
Patch rv1.1

Quite simple one-liner fix which affects only ISO-2022-JP messages.
But it's very important for Japanese users to search messages correctly.

Comment 7

[Scott MacGregor]

Comment on attachment 201732 [details] [diff] [review]
Patch rv1.1

please land this on the 1.8.1 branch for thunderbird 2 (or let me know if you need me to do it for you).

Comment 8

[Jungshik Shin]

landed on 1.8.1 branch

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 201732 [details] [diff] [review]
Patch rv1.1

Oops, sorry, I forgot this. This should go to 1.8.0 branch. This is low risk and good fix.

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 201732 [details] [diff] [review]
Patch rv1.1

Unfortunately we are already testing final candidate bits for 1.8.0.2 and this is not a stop-ship security hole. Looks good for 1.8.0.3 (which will be approved later, after we've tagged the cvs tree).

Comment 11

[Jay Patel [:jay]]

Comment on attachment 201732 [details] [diff] [review]
Patch rv1.1

Please check in promptly on the 1.8.0 branch.  Thanks!

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in to 1.8.0 branch, thanks.

Comment 13

[Jorg K (CEST = GMT+2)]

If anyone is still following this bug: The fix landed here was, well, a kludge on top of some mess. And it landed without a test. I removed all the mess and added tests here: https://hg.mozilla.org/comm-central/rev/9211c27bcce1