314786 - Cannot add to CC-list of bug 314759 (You tried to change the Keywords field)

Status: RESOLVED WORKSFORME

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[J.P.Klippel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051101 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051101 Firefox/1.6a1

When I try to add myself to the cc-list of this bug using the checkbox Add to CC-list or using the input field I get the following error:
"You tried to change the Keywords field from testcase, assertion  to assertion, testcase  , but only the assignee or reporter of the bug, or a sufficiently empowered user may change that field."
I did not touch this field. I tried several times with different browsers. It seems as if bugzilla "sorts" the field when I load the bug.

Reproducible: Always

Steps to Reproduce:
1. open bug 314759 in bugzilla

Actual Results:  
Error message:
You tried to change the Keywords field from testcase, assertion  to assertion, testcase  , but only the assignee or reporter of the bug, or a sufficiently empowered user may change that field.

Expected Results:  
adding myself to the CC list

Comment 1

[timeless]

steps:
1. i removed myself from canconfirm+editbugs
2. i loaded bug 314759
3. i clicked [x] Add [e-mail] to CC list
4. i clicked commit

i'm now a cc to that bug (not that it really matters.

someone w/ server side access needs to check to see if there's something else going on, but this WFM.

Comment 2

[J.P.Klippel]

now it works for me too. 
I guess the server sorted the keywords when it served the page to me. I am not allowed to switch keywords. That's why I get an error. 
Do you (timeless@...) have the right to change keywords?
That would explain. The server sorts the keywords and you commit the change. No problem here. When I return I can add myself to the CC list, as the keywords are in the correct order (in the bug database, too).
You might try to change the order of the keywords back to testcase, assertion and retry adding with an user with lesser priveledges. 

(It's just my 2 cents. Maybe it's not that way at all.)

Comment 3

[Frédéric Buclin]

keyword changes require editbugs privs too. Marking WFM.

Comment 4

[Marc Schumann [:Wurblzap]]

I'm not altogether sure that this is really a WFM bug. Should, for some reason, the bug contain non-sorted keywords (because of a rename, perhaps?), then you'll probably get this error.

Comment 5

[Teemu Mannermaa (:wicked)]

(In reply to comment #4)
> I'm not altogether sure that this is really a WFM bug. Should, for some reason,
> the bug contain non-sorted keywords (because of a rename, perhaps?), then
> you'll probably get this error.

I'm with Marc here. I just tested this with an unprivileged user on the tip and could trigger this error when keyword cache was not rebuild after changing keyword ordering. Merely loading and submitting a bug without any changes that had both keywords resulted in this keyword error because process_bug.cgi was comparing differently sorted keyword strings.

This can also be triggered by changing the order of the keywords manually. OK it could be argued that this is, atleast in theory, a keyword change that you are not allowed to do.

I'm wondering if there is a missing keyword string sort for the form field before doing a compare? Reopening so that we don't loose this bug and so that everybody get to reconsider this bug again. :)

Comment 6

[Marc Schumann [:Wurblzap]]

This might be related to, or even a duplicate of, bug 69621.

Comment 7

[Frédéric Buclin]

wicked, can you still reproduce this bug?

Comment 8

[Teemu Mannermaa (:wicked)]

Yes, I can reproduce this bug. Fixing bug 69621 by automatically updating keyword cache after a keyword change should fix this bug because error doesn't happen anymore after I run the cache update using sanitycheck.

Comment 9

[Frédéric Buclin]

The keyword cache no longer exists in Bugzilla 3.7, see bug 69621, and there is no plan to fix this problem on older branches. WFM.