314795 - [Oracle] SQL query in query.cgi is missing a space

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Lance Larsh]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041119
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041119

The query for retrieving the logged in user's named queries (around line 393 of query.cgi), created by concatenating several Perl strings, is:

   "SELECT name FROM namedqueries WHERE userid = ? and name != ?ORDER BY name"

Note that there is no whitespace between the second "?" and "ORDER BY".  This causes a SQL parsing error when running on Oracle, preventing the Search page from being displayed.

Reproducible: Always

Steps to Reproduce:
1.  Log into a Bugzilla installation using an Oracle database.
2.  Click the "Search" action link in the page footer.


Actual Results:  
Instead of showing the Search page, the browser shows:

Software error:
  DBD::Oracle::db selectcol_arrayref failed:
    ORA-00933: SQL command not properly ended
    (DBD ERROR: error possibly near <*> indicator at char 70 in
    'SELECT name FROM namedqueries WHERE userid = :p1 AND name != :p2ORDER <*>BY name')

Expected Results:  
The Search page should appear.

Comment 1

[Lance Larsh]

Attachment: Patch to add a single space to query

Comment 2

[Max Kanat-Alexander]

Wow, I'm surprised that ever worked. :-)

Comment 3

[Max Kanat-Alexander]

Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.154; previous revision: 1.153
done