314821 - Stop building dist/gre

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

We aren't using dist/gre for anything: the old GRE (seamonkey) is using manifests, and XULRunner will be the GRE shipping directly out of dist/bin. So let's get rid of the build automation for it now.

Comment 1

[Benjamin Smedberg]

Attachment: Stop building dist/gre, rev. 1

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 201672 [details] [diff] [review]
Stop building dist/gre, rev. 1

all that work for nothing, chris? ;-)

Comment 3

[Benjamin Smedberg]

Fixed on trunk, that was fast!

Comment 4

[Wan-Teh Chang]

Is it okay to check in this patch on the MOZILLA_1_8_BRANCH?
I need to backport a patch from the trunk to the MOZILLA_1_8_BRANCH.
It would make the job easier if I don't need to update the makefile
code inside ifndef DISABLE_DIST_GRE.

Comment 5

[Wan-Teh Chang]

Attachment: Patch for MOZILLA_1_8_BRANCH

Ben, I found that after you checked in the patch (attachment 201672 [details] [diff] [review])
on the trunk, you also changed config/Makefile.in and config/config.mk.
This patch captures all the changes that I know of for this bug.  Did
I miss anything?

Comment 6

[Benjamin Smedberg]

Comment on attachment 210629 [details] [diff] [review]
Patch for MOZILLA_1_8_BRANCH

I'm pretty sure you removed one too many PREF_DIST_DIR sets in rules.mk... you need to keep PREF_DIST_DIR = $(FINAL_TARGET) or replace the usage of $(PREF_DIST_DIR)

Comment 7

[Wan-Teh Chang]

Comment on attachment 210629 [details] [diff] [review]
Patch for MOZILLA_1_8_BRANCH

Ben, the config/rules.mk changes in this patch are
the same as the config/rules.mk changes in your
rev. 1 patch for the trunk (attachment 201672 [details] [diff] [review]).
LXR of mozilla1.8 also shows that PREF_DIST_DIR
is only defined and used in config/rules.mk.
This patch and your patch remove all definitions
and uses of PREF_DIST_DIR.  So I don't understand
your review comment.

Comment 8

[Wan-Teh Chang]

Comment on attachment 210629 [details] [diff] [review]
Patch for MOZILLA_1_8_BRANCH

> ifndef NO_DIST_INSTALL
>-libs:: $(PREF_JS_EXPORTS) $(PREF_DIST_DIR)/$(PREF_DIR)
>-	$(EXIT_ON_ERROR)  \
>-	for i in $(PREF_JS_EXPORTS); \
>-	do $(PERL) $(topsrcdir)/config/preprocessor.pl $(PREF_PPFLAGS) $(DEFINES) $(ACDEFINES) $$i > $(PREF_DIST_DIR)/$(PREF_DIR)/`basename $$i`; \
>-	done
>-
>-ifdef GRE_MODULE
>-ifndef _SKIP_OLD_GRE_INSTALL
> libs:: $(PREF_JS_EXPORTS) $(FINAL_TARGET)/$(PREF_DIR)
> 	$(EXIT_ON_ERROR)  \
> 	for i in $(PREF_JS_EXPORTS); \
> 	do $(PERL) $(topsrcdir)/config/preprocessor.pl $(PREF_PPFLAGS) $(DEFINES) $(ACDEFINES) $$i > $(FINAL_TARGET)/$(PREF_DIR)/`basename $$i`; \
> 	done
> endif
>-endif
>-endif

Ben, I believe you are worried that removing the
PREF_DIST_DIR sets will break the above code in
rules.mk  It won't, because the remaining code
already uses $(FINAL_TARGET) instead of
$(PREF_DIST_DIR).

Comment 9

[Benjamin Smedberg]

Comment on attachment 210629 [details] [diff] [review]
Patch for MOZILLA_1_8_BRANCH

My bad, I was misreading the patch.

Comment 10

[Wan-Teh Chang]

Thanks, Ben.  I've checked in the patch on the
MOZILLA_1_8_BRANCH.