314844 - "About Mozilla Firefox" menuitem should be labeled "About Firefox"

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[dynamis (Tomoya ASAI)]

"About Mozilla Firefox" menuitem should be labeled "About Firefox" on Mac OS.

See Apple Human Interface Guidelines:
http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGMenus/chapter_16_section_4.html#//apple_ref/doc/uid/TP30000356-TPXREF135
  About ApplicationName.
Opens your application’s About window, which contains copyright information and version number. (For more information, see "About Windows". If you’ve specified a short name (see "The Application Menu Title"), use it in the About menu item; use the full application name in the About window.

relating (but not depending/blocking) bugs: 238138, 307455

Comment 1

[Adam Kaplan]

Asai is correct. Additionally the minimize window control is active.  The spec states that only the the close control be active. These sounds trivial to fix, i'm going to give it a go tonight.

Comment 2

[Markus Amalthea Magnuson]

Attachment: Changes "About Mozilla Firefox" to "About Firefox" on Mac

Here's a patch to change the about menu title from "About Mozilla Firefox" to "About Firefox" on Mac, according to the HIG as mentioned.

Comment 3

[Jennifer Morrow [:Boriss] (UX)]

We should probably just change this on all platforms.  Markus, are you good to do that?

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 403336 [details] [diff] [review]
Changes "About Mozilla Firefox" to "About Firefox" on Mac

Good, but I would make the change on all platforms as well.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

OK, so lets just change s/brandFullName/brandShortName/, and rename the entity so that localizers will notice the change (unlikely to matter, I think, but better to be safe than sorry).

Comment 6

[Markus Amalthea Magnuson]

Attachment: Changes "About Mozilla Firefox" to "About Firefox" on all platforms

Here's a new patch that changes the menu title to "About Firefox" on all platforms and also renames the entity, all according to comment 5. Only tested on mac, and needs to be built with --enable-official-branding to be properly tested.

Would a separate patch be needed for the 3.6-branch? I am kind of new to patching Firefox so I am not familiar with the trunk/branch patch procedure.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 403383 [details] [diff] [review]
Changes "About Mozilla Firefox" to "About Firefox" on all platforms

Thanks for the patch!

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> Would a separate patch be needed for the 3.6-branch? I am kind of new to
> patching Firefox so I am not familiar with the trunk/branch patch procedure.

No separate patch needed. I think we're string frozen on the branch now, though, which means we wouldn't be able to land it there.

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/d0688378a183