314927 - make install does not put default.xpm into $(DESTDIR)$(mozappdir)/chrome/icons/default

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Sylvain Pasche]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051103 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051103 Firefox/1.6a1

After doing make install, the default.xpm icon is copied into  $(DESTDIR)$(mozappdir)/icons (for instance /usr/local/lib/firefox-1.6a1/icons), but not into $(DESTDIR)$(mozappdir)/chrome/icons/default where it looks like firefox is looking for the default.xpm icon.
I'm using the gtk2 graphical backend.

Here's the relevent line in browser/app/Makefile.in:

ifeq ($(MOZ_WIDGET_TOOLKIT),gtk2)
libs::
        $(INSTALL) $(DIST)/branding/default.xpm $(DIST)/bin/chrome/icons/default

install::
        $(SYSINSTALL) $(IFLAGS1) $(DIST)/branding/default.xpm $(DESTDIR)$(mozappdir)/icons


One workaround is to change the last line into

        $(SYSINSTALL) $(IFLAGS1) $(DIST)/branding/default.xpm $(DESTDIR)$(mozappdir)/chrome/icons/default



Reproducible: Always

Comment 1

[cls]

Attachment: v1.0

Use the correct path for the icon.

Comment 2

[cls]

Checking in browser/app/Makefile.in;
/cvsroot/mozilla/browser/app/Makefile.in,v  <--  Makefile.in
new revision: 1.92; previous revision: 1.91
done

Comment 3

[Mike Hommey [:glandium]]

Please reopen and apply the same fix to mail/app/Makefile.in and xulrunner/app/Makefile.in

Comment 4

[Sylvain Pasche]

I'm not a mozilla developer and I think your message has not been seen by one.

Maybe you should create two new bugs. One with (product, component) pair set to (Toolkit, Xulrunner) and one with (Thunderbird, Buildconfig) each one with the ported patch and a comment saying they should be commited together. I know this may be overkill for such a tiny change, but it's quite hard to get attention from developers sometimes.

Comment 5

[Sylvain Pasche]

oops, maybe I'm wrong.

I forgot there a more people receiving mail on this bug that just the people on the CC, sorry.

Comment 6

[Mike Hommey [:glandium]]

calendar/sunbird/app/Makefile.in as well.

Comment 7

[Mike Hommey [:glandium]]

O_o seems I gained the privilege to be able to reopen bugs...

Comment 8

[Mike Hommey [:glandium]]

Attachment: Patch for thunderbird, xulrunner and sunbird

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/xulrunner/app/Makefile.in 	1.31
mozilla/mail/app/Makefile.in 	1.58
mozilla/calendar/sunbird/app/Makefile.in 	1.33