Closed Bug 314927 Opened 14 years ago Closed 14 years ago

make install does not put default.xpm into $(DESTDIR)$(mozappdir)/chrome/icons/default

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla3 alpha1

People

(Reporter: sylvain.pasche, Assigned: glandium)

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051103 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051103 Firefox/1.6a1

After doing make install, the default.xpm icon is copied into  $(DESTDIR)$(mozappdir)/icons (for instance /usr/local/lib/firefox-1.6a1/icons), but not into $(DESTDIR)$(mozappdir)/chrome/icons/default where it looks like firefox is looking for the default.xpm icon.
I'm using the gtk2 graphical backend.

Here's the relevent line in browser/app/Makefile.in:

ifeq ($(MOZ_WIDGET_TOOLKIT),gtk2)
libs::
        $(INSTALL) $(DIST)/branding/default.xpm $(DIST)/bin/chrome/icons/default

install::
        $(SYSINSTALL) $(IFLAGS1) $(DIST)/branding/default.xpm $(DESTDIR)$(mozappdir)/icons


One workaround is to change the last line into

        $(SYSINSTALL) $(IFLAGS1) $(DIST)/branding/default.xpm $(DESTDIR)$(mozappdir)/chrome/icons/default



Reproducible: Always
Attached patch v1.0Splinter Review
Use the correct path for the icon.
Attachment #202328 - Flags: review?(benjamin)
Attachment #202328 - Flags: review?(benjamin) → review+
Checking in browser/app/Makefile.in;
/cvsroot/mozilla/browser/app/Makefile.in,v  <--  Makefile.in
new revision: 1.92; previous revision: 1.91
done
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.6-
Please reopen and apply the same fix to mail/app/Makefile.in and xulrunner/app/Makefile.in
I'm not a mozilla developer and I think your message has not been seen by one.

Maybe you should create two new bugs. One with (product, component) pair set to (Toolkit, Xulrunner) and one with (Thunderbird, Buildconfig) each one with the ported patch and a comment saying they should be commited together. I know this may be overkill for such a tiny change, but it's quite hard to get attention from developers sometimes.
oops, maybe I'm wrong.

I forgot there a more people receiving mail on this bug that just the people on the CC, sorry.
calendar/sunbird/app/Makefile.in as well.
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---
O_o seems I gained the privilege to be able to reopen bugs...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #218141 - Flags: review?(benjamin) → review+
Whiteboard: [checkin needed]
Assignee: nobody → mh+mozilla
mozilla/xulrunner/app/Makefile.in 	1.31
mozilla/mail/app/Makefile.in 	1.58
mozilla/calendar/sunbird/app/Makefile.in 	1.33
Status: NEW → RESOLVED
Closed: 14 years ago14 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: Firefox 2 → Firefox 3 alpha1
Version: unspecified → Trunk
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 3 alpha1 → mozilla3 alpha1
You need to log in before you can comment on or make changes to this bug.