314933 - initial focus should be on the "Problem type" menulist, not the url field

Status: RESOLVED FIXED

(Other Applications Graveyard :: Reporter, enhancement, P5)

Description

[:Gavin Sharp [email: [e-mail]]]

Probably as easy as putting a tabindex="0" on it.

Comment 1

[Asa Dotzler [:asa]]

This is a near-zero risk change that can only impact reporter. if there's a chance to get it in, it'll make the reporter more functional. if not, I understand.

Comment 2

[Robert Accettura [:raccettura]]

Attachment: Patch v1

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 201765 [details] [diff] [review]
Patch v1

low-risk, doesn't impact anything outside of reporter wizard, and fixes the wizard's behaviour.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Does that patch actually work? Seems like the menulist doesn't properly inherit the tabindex attribute.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: other patch

The other patch didn't work for me, this one does. That one's nicer, and maybe I did something wrong applying it (I don't currently have a build env), so if it works just ignore this.

Comment 6

[Robert Accettura [:raccettura]]

Strange that first patch should work according to this:
http://xulplanet.com/references/elemref/ref_menulist.html#attr_tabindex

Looking at the 2nd patch.  Didn't work the first time.  Perhaps it's a cache issue.

Comment 7

[Axel Hecht]

Just to add to the confusion, I just recently saw platform dependencies with
initial focus (something.focus() didn't help on linux, but helped on windows).

Comment 8

[Robert Accettura [:raccettura]]

Comment on attachment 201766 [details] [diff] [review]
other patch

Lets land this

Comment 9

[Robert Accettura [:raccettura]]

Comment on attachment 201766 [details] [diff] [review]
other patch

This should make 1.8.1.  UI Fix, no real risk.

Comment 10

[Mike Schroepfer]

Comment on attachment 201766 [details] [diff] [review]
other patch

181 Drivers realizes that this is a low-risk fix - but we are closing in on our RC1 code freeze and are only at this point taking bugs thats match the criteria for 181 approvals:

http://developer.mozilla.org/devnews/index.php/2006/08/28/firefox-2gecko-181-approvals-2/

Comment 11

[Robert Accettura [:raccettura]]

Checked in on trunk.