initial focus should be on the "Problem type" menulist, not the url field

RESOLVED FIXED in mozilla1.9alpha

Status

P5
enhancement
RESOLVED FIXED
14 years ago
4 months ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

unspecified
mozilla1.9alpha
Bug Flags:
blocking1.8rc2 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Probably as easy as putting a tabindex="0" on it.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.9alpha

Comment 1

14 years ago
This is a near-zero risk change that can only impact reporter. if there's a chance to get it in, it'll make the reporter more functional. if not, I understand.
Flags: blocking1.8rc2?
Comment on attachment 201765 [details] [diff] [review]
Patch v1

low-risk, doesn't impact anything outside of reporter wizard, and fixes the wizard's behaviour.
Attachment #201765 - Flags: review+
Does that patch actually work? Seems like the menulist doesn't properly inherit the tabindex attribute.
Created attachment 201766 [details] [diff] [review]
other patch

The other patch didn't work for me, this one does. That one's nicer, and maybe I did something wrong applying it (I don't currently have a build env), so if it works just ignore this.
Strange that first patch should work according to this:
http://xulplanet.com/references/elemref/ref_menulist.html#attr_tabindex

Looking at the 2nd patch.  Didn't work the first time.  Perhaps it's a cache issue.

Comment 7

14 years ago
Just to add to the confusion, I just recently saw platform dependencies with
initial focus (something.focus() didn't help on linux, but helped on windows).

Updated

14 years ago
Flags: blocking1.8rc2? → blocking1.8rc2-
Priority: -- → P5
Comment on attachment 201766 [details] [diff] [review]
other patch

Lets land this
Attachment #201766 - Flags: review+
Attachment #201765 - Attachment is obsolete: true
Comment on attachment 201766 [details] [diff] [review]
other patch

This should make 1.8.1.  UI Fix, no real risk.
Attachment #201766 - Flags: approval1.8.1?
Summary: inital focus should be on the "Problem type" menulist, not the url field → initial focus should be on the "Problem type" menulist, not the url field

Comment 10

13 years ago
Comment on attachment 201766 [details] [diff] [review]
other patch

181 Drivers realizes that this is a low-risk fix - but we are closing in on our RC1 code freeze and are only at this point taking bugs thats match the criteria for 181 approvals:

http://developer.mozilla.org/devnews/index.php/2006/08/28/firefox-2gecko-181-approvals-2/
Attachment #201766 - Flags: approval1.8.1? → approval1.8.1-
Checked in on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

4 months ago
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.