314961 - Won't build when using spaces in --enable-optimize and having dash as sh

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8) Gecko/20051101 Debian/1.4.99+1.5rc1.dfsg-1 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8) Gecko/20051101 Debian/1.4.99+1.5rc1.dfsg-1 Firefox/1.5

Because of a bug in dash, when using ./configure --enable-optimize="-someoption -someother" (with a space in the statement), MOZ_OPTIMIZE_FLAGS in config/automake.cf is truncated after a backslash, thus adding MOZ_OPTIMIZE_LDFLAGS = in the variable and breaking build. (See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=211010 if you want some more detail).

There is a simple workaround that makes it work in all cases, that i am going to attach.

Reproducible: Always

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch

Note the patch also contains the changes to configure so that anyone can try the patch without running autoconf...

Comment 2

[Mike Hommey [:glandium]]

should i ask for superreview ? in such case who should i ask to ?

Comment 3

[Andrew Schultz]

build config patches don't need SR

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on trunk. thanks for the patch!

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1620; previous revision: 1.1619
done

Comment 5

[Benjamin Smedberg]

Fixed on 1.8 branch (for ff2).