315021 - ret_cr16.s is in the wrong directory

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Julien Pierre]

There is a file called lib/util/ret_cr16.s which provides the value of the highres timer on HP-UX itanium apparently. The function is only used by freebl.
I think the source file should be moved to the freebl subdirectory.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

This code is the "high res" timer for the older PA-Risc CPUs.
I agree that it should move into freebl.

Note that this code is used for all PA_Risc CPUs, including the old 1.1 CPUs
and the newer 2.0 CPUs.  In that respect it differs from the HP assembly 
files in freebl/mpi, which are only built for 2.0 CPUs.

Comment 2

[Julien Pierre]

Attachment: move assembly source to freebl

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 201814 [details] [diff] [review]
move assembly source to freebl

Looks right to me. r=nelson

Comment 4

[Julien Pierre]

Thanks for the quick review, Nelson. I checked this in for 3.11 .

Checking in freebl/Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/Makefile,v  <--  Makefile
new revision: 1.67; previous revision: 1.66
done
RCS file: /cvsroot/mozilla/security/nss/lib/freebl/ret_cr16.s,v
done
Checking in freebl/ret_cr16.s;
/cvsroot/mozilla/security/nss/lib/freebl/ret_cr16.s,v  <--  ret_cr16.s
initial revision: 1.1
done
Checking in util/Makefile;
/cvsroot/mozilla/security/nss/lib/util/Makefile,v  <--  Makefile
new revision: 1.7; previous revision: 1.6
done
Removing util/ret_cr16.s;
/cvsroot/mozilla/security/nss/lib/util/ret_cr16.s,v  <--  ret_cr16.s
new revision: delete; previous revision: 1.1
done