Closed Bug 315021 Opened 15 years ago Closed 15 years ago
_cr16 .s is in the wrong directory
There is a file called lib/util/ret_cr16.s which provides the value of the highres timer on HP-UX itanium apparently. The function is only used by freebl. I think the source file should be moved to the freebl subdirectory.
This code is the "high res" timer for the older PA-Risc CPUs. I agree that it should move into freebl. Note that this code is used for all PA_Risc CPUs, including the old 1.1 CPUs and the newer 2.0 CPUs. In that respect it differs from the HP assembly files in freebl/mpi, which are only built for 2.0 CPUs.
Assignee: wtchang → julien.pierre.bugs
Status: NEW → ASSIGNED
Attachment #201814 - Flags: review?(nelson)
Comment on attachment 201814 [details] [diff] [review] move assembly source to freebl Looks right to me. r=nelson
Attachment #201814 - Flags: review?(nelson) → review+
Thanks for the quick review, Nelson. I checked this in for 3.11 . Checking in freebl/Makefile; /cvsroot/mozilla/security/nss/lib/freebl/Makefile,v <-- Makefile new revision: 1.67; previous revision: 1.66 done RCS file: /cvsroot/mozilla/security/nss/lib/freebl/ret_cr16.s,v done Checking in freebl/ret_cr16.s; /cvsroot/mozilla/security/nss/lib/freebl/ret_cr16.s,v <-- ret_cr16.s initial revision: 1.1 done Checking in util/Makefile; /cvsroot/mozilla/security/nss/lib/util/Makefile,v <-- Makefile new revision: 1.7; previous revision: 1.6 done Removing util/ret_cr16.s; /cvsroot/mozilla/security/nss/lib/util/ret_cr16.s,v <-- ret_cr16.s new revision: delete; previous revision: 1.1 done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Priority: -- → P2
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.