315034 - If search is set to open in a new tab, Alt+Enter should open the search result in the current tab

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Adam Guthrie]

If browser.search.openintab is set to true, Alt+Enter should open the search result in the current tab, just like Alt+Enter opens the search result in a new tab when this options is disabled.

Steps to reproduce:
1. Set browser.search.openintab to true.
2. Enter a search term and hit Alt+Enter.

Comment 1

[Adam Guthrie]

Attachment: patch by Mook

Comment 2

[O. Atsushi (Torisugari)]

IMHO, this functionality should be fixed together with bug 262575,
bug 262808, bug 263433 etc. (And I guess that's why this bug has been left out
for a long time by Gavin.)

Though I don't mean to complain about checking in this patch.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

This is a simple fix, I don't think it should depend on any of those more complicated bugs (which are about the other tabbed browsing prefs, as I understand it). Those are harder to fix because of the toolkit/browser dependencies, this one doesn't have that problem.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/search.xml; new revision: 1.34;

Comment 5

[:Gavin Sharp [email: [e-mail]]]

branch landing depends on bug 219532

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/search.xml; new revision: 1.25.2.10;