Closed
Bug 315034
Opened 19 years ago
Closed 19 years ago
If search is set to open in a new tab, Alt+Enter should open the search result in the current tab
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: ispiked, Assigned: ispiked)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
1.05 KB,
patch
|
robert.strong.bugs
:
review+
mconnor
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
If browser.search.openintab is set to true, Alt+Enter should open the search result in the current tab, just like Alt+Enter opens the search result in a new tab when this options is disabled. Steps to reproduce: 1. Set browser.search.openintab to true. 2. Enter a search term and hit Alt+Enter.
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #206664 -
Flags: review?(robert.bugzilla)
Updated•19 years ago
|
Attachment #206664 -
Flags: review?(robert.bugzilla) → review+
Comment 2•19 years ago
|
||
IMHO, this functionality should be fixed together with bug 262575, bug 262808, bug 263433 etc. (And I guess that's why this bug has been left out for a long time by Gavin.) Though I don't mean to complain about checking in this patch.
Comment 3•19 years ago
|
||
This is a simple fix, I don't think it should depend on any of those more complicated bugs (which are about the other tabbed browsing prefs, as I understand it). Those are harder to fix because of the toolkit/browser dependencies, this one doesn't have that problem.
Assignee: nobody → ispiked
Whiteboard: [checkin needed]
Comment 4•19 years ago
|
||
mozilla/browser/base/content/search.xml; new revision: 1.34;
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox1.6-
Updated•19 years ago
|
Attachment #206664 -
Flags: approval1.8.1?
Updated•19 years ago
|
Attachment #206664 -
Flags: approval1.8.1? → branch-1.8.1?(mconnor)
Updated•19 years ago
|
Attachment #206664 -
Flags: branch-1.8.1?(mconnor) → branch-1.8.1+
Comment 5•19 years ago
|
||
branch landing depends on bug 219532
Comment 6•19 years ago
|
||
mozilla/browser/base/content/search.xml; new revision: 1.25.2.10;
Keywords: fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•