315345 - Move nsIPermission to netwerk/base/public

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

nsIPermissionManager is in network/base/public and nsIPermission should be colocated with it (currently it's in extensions/cookie). I know this isn't a good final resting place but moving it to network/base/public is an immediate improvement.

This matters to embedders (e.g., Epiphany) who want to use XULrunner, because they need nsIPermission and extensions/cookie isn't packaged in XULrunner (nor should it be).

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: simple stuff

Comment 2

[Darin Fisher]

Comment on attachment 202055 [details] [diff] [review]
simple stuff

r+sr=darin for moving the file, but please have a cvs admin copy the file in the repository instead so as to preserve history.

By the way, Epiphany can easily get around this problem by having a copy of nsIPermission.idl in their source tree.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #2)
> (From update of attachment 202055 [details] [diff] [review] [edit])
> r+sr=darin for moving the file, but please have a cvs admin copy the file in
> the repository instead so as to preserve history.
> 
> By the way, Epiphany can easily get around this problem by having a copy of
> nsIPermission.idl in their source tree.

Yes. Although that would be a bit sucky.

Comment 4

[Darin Fisher]

> > By the way, Epiphany can easily get around this problem by having a copy of
> > nsIPermission.idl in their source tree.
> 
> Yes. Although that would be a bit sucky.

It's the approach I take when creating binary extensions to FF.  I start with the Gecko SDK, and then I have a directory containing the IDL files for non-frozen interfaces that I need from the Mozilla source.  (I sometimes have a couple variations on the same interface to deal with differences between FF 1.0 and 1.5, and I rename one of the interfaces so that I can code against both.)  The nice result of this is that I don't need to have a copy of the Mozilla source around to build my extension and neither does anyone else who wishes to build my extension.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

shouldn't this be removed from the old place?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

yes

Comment 8

[:Gavin Sharp [email: [e-mail]]]

I removed mozilla/extensions/cookie/nsIPermission.idl on the trunk.