Closed Bug 315427 Opened 16 years ago Closed 16 years ago

bad nullcheck in nsXULPrototypeElement::ReleaseSubtree

Categories

(Core :: XUL, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: fixed1.8.0.4, fixed1.8.1, memory-leak, Whiteboard: [patch])

Attachments

(1 file)

There's a wacky null-check in nsXULPrototypeElement::ReleaseSubtree that causes the rest of the subtree to be skipped.  This actually causes a leak when opening the Prefs dialog in Firefox, when the remembered panel is the cache panel (trunk build, Fri Nov 4 15:22:21 PST 2005, Linux/GTK2).
Attached patch patchSplinter Review
Attachment #202127 - Flags: superreview?(bryner)
Attachment #202127 - Flags: review?(bryner)
Status: NEW → ASSIGNED
Whiteboard: [patch]
Attachment #202127 - Flags: superreview?(bryner)
Attachment #202127 - Flags: superreview+
Attachment #202127 - Flags: review?(bryner)
Attachment #202127 - Flags: review+
Fix checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: blocking1.8.0.3?
Flags: blocking1.8.0.3? → blocking1.8.0.3+
Attachment #202127 - Flags: approval1.8.0.3?
Attachment #202127 - Flags: approval-branch-1.8.1?(bryner)
Attachment #202127 - Flags: approval-branch-1.8.1?(bryner) → approval-branch-1.8.1+
Checked in to MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1
Comment on attachment 202127 [details] [diff] [review]
patch

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #202127 - Flags: approval1.8.0.3? → approval1.8.0.3+
Fix checked in to MOZILLA_1_8_0_BRANCH.
Keywords: fixed1.8.0.3
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.