bad nullcheck in nsXULPrototypeElement::ReleaseSubtree

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
XUL
RESOLVED FIXED
12 years ago
9 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({fixed1.8.0.4, fixed1.8.1, mlk})

Trunk
mozilla1.9alpha1
x86
Linux
fixed1.8.0.4, fixed1.8.1, mlk
Points:
---
Bug Flags:
blocking1.8.0.4 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(1 attachment)

2.67 KB, patch
Brian Ryner (not reading)
: review+
Brian Ryner (not reading)
: superreview+
Brian Ryner (not reading)
: approval-branch-1.8.1+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
There's a wacky null-check in nsXULPrototypeElement::ReleaseSubtree that causes the rest of the subtree to be skipped.  This actually causes a leak when opening the Prefs dialog in Firefox, when the remembered panel is the cache panel (trunk build, Fri Nov 4 15:22:21 PST 2005, Linux/GTK2).
(Assignee)

Comment 1

12 years ago
Created attachment 202127 [details] [diff] [review]
patch
Attachment #202127 - Flags: superreview?(bryner)
Attachment #202127 - Flags: review?(bryner)
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
Whiteboard: [patch]
Attachment #202127 - Flags: superreview?(bryner)
Attachment #202127 - Flags: superreview+
Attachment #202127 - Flags: review?(bryner)
Attachment #202127 - Flags: review+
(Assignee)

Comment 2

12 years ago
Fix checked in to trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Flags: blocking1.8.0.3?
Flags: blocking1.8.0.3? → blocking1.8.0.3+
(Assignee)

Updated

11 years ago
Attachment #202127 - Flags: approval1.8.0.3?
Attachment #202127 - Flags: approval-branch-1.8.1?(bryner)
Attachment #202127 - Flags: approval-branch-1.8.1?(bryner) → approval-branch-1.8.1+
(Assignee)

Comment 3

11 years ago
Checked in to MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1
Comment on attachment 202127 [details] [diff] [review]
patch

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #202127 - Flags: approval1.8.0.3? → approval1.8.0.3+
(Assignee)

Comment 5

11 years ago
Fix checked in to MOZILLA_1_8_0_BRANCH.
Keywords: fixed1.8.0.3

Updated

9 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.