Last Comment Bug 315458 - xulappinfo.js.in should be included via EXTRA_PP_COMPONENTS
: xulappinfo.js.in should be included via EXTRA_PP_COMPONENTS
Status: RESOLVED FIXED
: fixed1.8
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: jag (Peter Annema)
:
:
Mentors:
: 316198 (view as bug list)
Depends on: 315907
Blocks:
  Show dependency treegraph
 
Reported: 2005-11-07 13:58 PST by Frank Wein [:mcsmurf]
Modified: 2005-12-05 05:05 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (856 bytes, patch)
2005-11-09 11:03 PST, Frank Wein [:mcsmurf]
benjamin: review+
neil: superreview+
Details | Diff | Splinter Review

Description Frank Wein [:mcsmurf] 2005-11-07 13:58:18 PST
The file xulappinfo.js.in uses the preprocessor to include the SeaMonkey version, appname, etc. But this information is only updated the first time the file is created (xulappinfo.js then), since it gets included via EXTRA_COMPONENTS. So when the SeaMonkey version changes, this file does not get updated (except you make clean). The file should be included in the Makefile via EXTRA_PP_COMPONENTS, then it gets preprocessed every compile run.
Comment 1 Robert Kaiser 2005-11-09 08:42:39 PST
I'm no expert on that stuff, and I might easily have done something incomplete there... can you tell where in the code that is?
Comment 2 Frank Wein [:mcsmurf] 2005-11-09 11:03:39 PST
Created attachment 202397 [details] [diff] [review]
Patch

This should fix it i think...xulappinfo.js.in needs to be moved/copied in CVS, will file bug for this then.
Comment 3 Benjamin Smedberg [:bsmedberg] 2005-11-10 08:44:06 PST
Comment on attachment 202397 [details] [diff] [review]
Patch

You're renaming the source file too, I presume.
Comment 4 Frank Wein [:mcsmurf] 2005-11-10 11:38:27 PST
Comment on attachment 202397 [details] [diff] [review]
Patch

Easy review i think :)
Comment 5 neil@parkwaycc.co.uk 2005-11-11 07:46:48 PST
Comment on attachment 202397 [details] [diff] [review]
Patch

Doh, took me this long to figure out the rename issue...
Comment 6 Andrew Schultz 2005-11-12 13:12:54 PST
*** Bug 316198 has been marked as a duplicate of this bug. ***
Comment 7 Frank Wein [:mcsmurf] 2005-11-16 07:21:42 PST
checked in by Neil.
Comment 8 Robert Kaiser 2005-11-16 13:26:12 PST
Comment on attachment 202397 [details] [diff] [review]
Patch

requesting branch approval: quite small SeaMonkey-specific fix
Comment 9 Robert Kaiser 2005-12-05 03:53:37 PST
Comment on attachment 202397 [details] [diff] [review]
Patch

re-requesting 1.8 branch approval for this SeaMonkey-only patch
Comment 10 Robert Kaiser 2005-12-05 03:55:07 PST
Comment on attachment 202397 [details] [diff] [review]
Patch

oh, wait... one should read all mail before reacting to some ;-)
Comment 11 Robert Kaiser 2005-12-05 05:05:18 PST
checked into branch (cleared to land by mtschrep in email to
seamonkey-council).

Note You need to log in before you can comment on or make changes to this bug.