The default bug view has changed. See this FAQ.

non-MOZILLA_INTERNAL_API code usage of dom/content headers

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
DOM
P2
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: bsmedberg, Assigned: bsmedberg)

Tracking

Trunk
mozilla1.9alpha1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
The Mozilla activex plugin/control needs to be built without MOZILLA_INTERNAL_API, but it needs to include nsIContent.h so it can pass a content object to nsILinkHandler. The forthcoming patch is a hack that allows the necessary headers to be included without breaking the build.
(Assignee)

Comment 1

12 years ago
Created attachment 202252 [details] [diff] [review]
Hack "nsStringGlue.h" and ifdefs for non-internal API use
Attachment #202252 - Flags: review?(jst)
(Assignee)

Updated

12 years ago
Blocks: 315563

Comment 2

12 years ago
Comment on attachment 202252 [details] [diff] [review]
Hack "nsStringGlue.h" and ifdefs for non-internal API use

>Index: content/base/public/nsIDocument.h

>+#ifndef MOZILLA_INTERNAL_API
>+// XXX Hack alert! These are only here to make this file compile, you can't
>+// actually use these to do anything useful with the frozen string API.
>+#define nsAFlatString nsAString
>+#define nsAFlatCString nsACString
>+#endif

nsAFlatString is a deprecated type even in the internal string API, and
it actually corresponds to nsString.  Why not add typedefs to nsStringAPI.h
in the deprecated section for this?  Or, change nsIDocument to use nsString
in place of nsAFlatString.
(Assignee)

Updated

12 years ago
Attachment #202252 - Flags: review?(jst)
(Assignee)

Comment 3

12 years ago
Created attachment 202287 [details] [diff] [review]
Hack "nsStringGlue.h" and ifdefs for non-internal API use
Attachment #202252 - Attachment is obsolete: true
Attachment #202287 - Flags: review?(jst)
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Comment on attachment 202287 [details] [diff] [review]
Hack "nsStringGlue.h" and ifdefs for non-internal API use

r=jst
Attachment #202287 - Flags: review?(jst) → review+
(Assignee)

Comment 5

12 years ago
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.