315562 - non-MOZILLA_INTERNAL_API code usage of dom/content headers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Benjamin Smedberg]

The Mozilla activex plugin/control needs to be built without MOZILLA_INTERNAL_API, but it needs to include nsIContent.h so it can pass a content object to nsILinkHandler. The forthcoming patch is a hack that allows the necessary headers to be included without breaking the build.

Comment 1

[Benjamin Smedberg]

Attachment: Hack "nsStringGlue.h" and ifdefs for non-internal API use

Comment 2

[Darin Fisher]

Comment on attachment 202252 [details] [diff] [review]
Hack "nsStringGlue.h" and ifdefs for non-internal API use

>Index: content/base/public/nsIDocument.h

>+#ifndef MOZILLA_INTERNAL_API
>+// XXX Hack alert! These are only here to make this file compile, you can't
>+// actually use these to do anything useful with the frozen string API.
>+#define nsAFlatString nsAString
>+#define nsAFlatCString nsACString
>+#endif

nsAFlatString is a deprecated type even in the internal string API, and
it actually corresponds to nsString.  Why not add typedefs to nsStringAPI.h
in the deprecated section for this?  Or, change nsIDocument to use nsString
in place of nsAFlatString.

Comment 3

[Benjamin Smedberg]

Attachment: Hack "nsStringGlue.h" and ifdefs for non-internal API use

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 202287 [details] [diff] [review]
Hack "nsStringGlue.h" and ifdefs for non-internal API use

r=jst

Comment 5

[Benjamin Smedberg]

Fixed on trunk.