315578 - Pause button disappears from customize sheet when download is in manager

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[Graeme Porteous]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051107 Camino/1.0b1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051107 Camino/1.0b1

The pause icon and title disappears from customize toolbar sheet when there is a download is in manager. It leave a blank space in it's place.

Reproducible: Always

Steps to Reproduce:
1. Make sure there is at least one download in the manager.
2. Show the toolbar customize toolbar sheet from the view menu.
Actual Results:  
Icon and title disapper, but a space is left.

Expected Results:  
Should be able to see the pause icon and title.

Comment 1

[Samuel Sidler (old account; do not CC)]

Confirmed.

Comment 2

[Simon Fraser [no longer active]]

WFM

Comment 3

[Samuel Sidler (old account; do not CC)]

Here's what I do:
1. Download a file, any file.
2. When it's finished (I usually download something small), right click on the toolbar and select "Customize Toolbar"
3. Look to see the Pause icon.

It is gone. As soon as you "clear" the download view, it returns to the customize toolbar sheet.

Comment 4

[froodian (Ian Leue)]

This only happens if the download is selected in the downloads window.  That is, if you command-click the download so it's unselected, the pause button reappears in the sheet.  (noticed by Wevah)

Happens as early as 1.0a1 (possibly earlier)

Comment 5

[Samuel Sidler (old account; do not CC)]

This probably isn't a regression then. However, I'm going to leave the keyword until we know for sure. Can someone go back to when the pause/resume download patch first landed (August 3's nightly should have been the first to have it) and check if this problem exists?

Comment 6

[froodian (Ian Leue)]

This problem exists from the first nightly to contain the pause/resume download patch (2005080408).

Comment 7

[Samuel Sidler (old account; do not CC)]

Not a regression.

Comment 8

[Nick Kreeger]

Attachment: Proposed patch

The problem is that since we get our groove on when swapping between pause and resume functionality that the buttons get validated in |setPauseResumeToolbarItem:| and right after a download completes, a download can no longer be paused or resumed, but that is what the customize dialog was going off of and set the items in the sheet accordingly.

This just sets the items as "pause" values except we don't hook a selector to it.

Comment 9

[Josh Aas]

landed on trunk and branch