315648 - nsCSSSelector::ToStringInternal sometimes fails to serialize "*" when needed

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

As I pointed out in an "XXXldb" comment in the patch on bug 315567, nsCSSSelector::ToStringInternal sometimes doesn't serialize the "*" for the element even when a namespace is present.  It should remember that a namespace was serialized and be sure to serialize the "*".

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch (diff -u)

I tested that this gives minimal output for attachment 202342 [details], attachment 202342 [details] modified to add a default namespace the same as html, and attachment 202342 [details] modified to add a default namespace different from html.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch (diff -ub)

Comment 4

[Boris Zbarsky [:bzbarsky]]

I'll try to get to this in the next day or two... Sorry this is taking so long.  :(

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 202350 [details] [diff] [review]
patch (diff -ub)

r+sr=bzbarsky

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk.