Camino is slow to quit with a large history

RESOLVED FIXED in Camino1.0

Status

P3
normal
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: sfraser_bugs, Assigned: sfraser_bugs)

Tracking

({fixed1.8, perf})

Trunk
Camino1.0
PowerPC
macOS
fixed1.8, perf
Bug Flags:
camino1.0 +

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
If you've viewed the history in a window, then quit with that window still open, Camino can take seconds to quit. Some profiling shows that we are erroneously rebuilding the history data source after expiring history entries.
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
Flags: camino1.0+
Keywords: perf
Priority: -- → P3
Target Milestone: --- → Camino1.0
(Assignee)

Comment 1

14 years ago
Posted patch PatchSplinter Review
This is a classic "array changing during enumeration" problem; the Obj-C data source was removing its history observer in the HistoryClosing() callback, causing one of the observers to get skipped, so the data source for that ignored observer was still receiving start/end batch notifications.

The fix is to clone the array before enumerating it.
Comment on attachment 202341 [details] [diff] [review]
Patch

good catch, r=pink if you want it.
Attachment #202341 - Flags: review+
(Assignee)

Comment 3

14 years ago
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.