Closed Bug 315667 Opened 19 years ago Closed 19 years ago

Camino is slow to quit with a large history

Categories

(Camino Graveyard :: History, defect, P3)

PowerPC
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Camino1.0

People

(Reporter: sfraser_bugs, Assigned: sfraser_bugs)

Details

(Keywords: fixed1.8, perf)

Attachments

(1 file)

If you've viewed the history in a window, then quit with that window still open, Camino can take seconds to quit. Some profiling shows that we are erroneously rebuilding the history data source after expiring history entries.
Status: NEW → ASSIGNED
Flags: camino1.0+
Keywords: perf
Priority: -- → P3
Target Milestone: --- → Camino1.0
Attached patch PatchSplinter Review
This is a classic "array changing during enumeration" problem; the Obj-C data source was removing its history observer in the HistoryClosing() callback, causing one of the observers to get skipped, so the data source for that ignored observer was still receiving start/end batch notifications.

The fix is to clone the array before enumerating it.
Comment on attachment 202341 [details] [diff] [review]
Patch

good catch, r=pink if you want it.
Attachment #202341 - Flags: review+
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: