315786 - Make the functions defined in nsEscape.h more useful

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Darin Fisher]

Make the functions defined in nsEscape.h more useful

For example, it is a pain to escape/unescape UTF-16 strings.  NS_EscapeURL and NS_UnescapeURL all have versions that return nsACString references that helps avoid copying when unnecessary.  However, many consumers would be happier with a nsCSubstring reference or a nsCString reference.  We can easily support other inline variants on those methods that makes the APIs easier to use.

Comment 1

[Darin Fisher]

Attachment: v1 patch

This patch cleans up the string types (dropping the deprecated string class names) and adds versions of NS_EscapeURL that operate on nsCSubstring.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 202610 [details] [diff] [review]
v1 patch

could use BeginReading() these days, and avoid the temp variable

I wonder if making these templates would be a good idea? It'd avoid having all these copies of the function in this file.

Oh, and couldn't you make the first argument an nsACString&, now that it has a BeginReading() method?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

(one that returns a const char*, that is)

Comment 4

[Darin Fisher]

Attachment: v1.1 patch

Here's the version that I ended up checking in.  I realized that my first patch would not work if compiled without MOZ_V1_STRING_ABI.

Comment 5

[Darin Fisher]

fixed-on-trunk