315870 - The broken JPEG/GIF image is not announced if Firefox loaded the image directly (The case of PNG, it works fine)

Status: RESOLVED WORKSFORME

(Core :: Graphics: ImageLib, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

See http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2953&action=view
This is invalid JPEG file(image/jpeg). Of course, we cannot display this image.
But the announcement for broken image isn't displaied.
This may be regression of Bug 292503.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

Invalid GIF:
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2956&action=view

Invalid PNG:
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2955&action=view

On the case of png image, the error message is displaied.
We have a problem only JPEG and GIF error handling.

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

  if (NS_FAILED(status) && imgDoc->mStringBundle && imgDoc->mImageContent) {

I traced it in a debugger, and status is 0.  I'm pretty sure that's not my fault.

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #2)
>   if (NS_FAILED(status) && imgDoc->mStringBundle && imgDoc->mImageContent) {
> 
> I traced it in a debugger, and status is 0.  I'm pretty sure that's not my
> fault.
> 

Just to clarify, I don't think the problem is with my code, but my change made another problem visible.

Comment 4

[Masatoshi Kimura [:emk]]

I can no longer reproduce a problem on Minefield trunk.
-> WFM