315906 - [BeOS]Slow update of asynchronous painting at scroll

Status: RESOLVED FIXED

(Core Graveyard :: Widget: BeOS, defect)

Description

[Sergei Dolgov]

Elements which are repainted through native update mechanics (via BView::Invalidate/Draw()) lags in update during scroll.

That's because we don't do in nsWindow::Update() what it should do - trigger immediate update drawing.
Partially it was by decision - whole draing speed wasn't strongest side of BeOS port.
But now we can try to rewrite it.

Comment 1

[Sergei Dolgov]

Attachment: patch

Introduces common for sync, async and native drawing update area.
Besides paintregion related changes, also returns "default" 3-lines value for scroll-wheel step

Comment 2

[Sergei Dolgov]

Attachment: patch, complete

Same as previous, but changes for *.h added

Comment 3

[Sergei Dolgov]

Comment on attachment 204026 [details] [diff] [review]
patch, complete

review request

Comment 4

[tqh]

Comment on attachment 204026 [details] [diff] [review]
patch, complete

r=[e-mail]
Please fix intendation though, header has two lines wrapped into one for instance.
(IMHO also remove some blank lines)

Can't really test it as my current tree calls into debugger a lot (every view creation and destruction) but it seems ok.

Comment 5

[Sergei Dolgov]

Attachment: patch

for Nielx/1.8* convinience - adjusted identation, in other aspects all exactly as in previous

Comment 6

[Sergei Dolgov]

landed in trunk
Checking in mozilla/widget/src/beos/nsWindow.h;
/cvsroot/mozilla/widget/src/beos/nsWindow.h,v  <--  nsWindow.h
new revision: 1.47; previous revision: 1.46
done
Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.112; previous revision: 1.111
done 

Closing.

Comment 7

[Niels Reedijk]

Attachment: Patch for 1_8 branch

Requesting approval for landing on the MOZILLA_1_8_BRANCH. 

This is a BeOS-only change and does not affect other platforms.

Comment 8

[Sergei Dolgov]

Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.91.4.22; previous revision: 1.91.4.21
done
Checking in mozilla/widget/src/beos/nsWindow.h;
/cvsroot/mozilla/widget/src/beos/nsWindow.h,v  <--  nsWindow.h
new revision: 1.35.4.13; previous revision: 1.35.4.12
done