Closed Bug 315906 Opened 19 years ago Closed 19 years ago

[BeOS]Slow update of asynchronous painting at scroll

Categories

(Core Graveyard :: Widget: BeOS, defect)

Product:
Core Graveyard
Component:
Widget: BeOS
Platform:
x86
BeOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sergei_d, Assigned: sergei_d)

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 2 obsolete files)

patch
17.54 KB, patch
Details | Diff | Splinter Review
Patch for 1_8 branch
18.58 KB, patch
dbaron
: approval1.8.1+
Details | Diff | Splinter Review 
Elements which are repainted through native update mechanics (via BView::Invalidate/Draw()) lags in update during scroll.

That's because we don't do in nsWindow::Update() what it should do - trigger immediate update drawing.
Partially it was by decision - whole draing speed wasn't strongest side of BeOS port.
But now we can try to rewrite it.
Attached patch patch (obsolete) — — Splinter Review 
Introduces common for sync, async and native drawing update area.
Besides paintregion related changes, also returns "default" 3-lines value for scroll-wheel step
Assignee: nobody → sergei_d
Status: NEW → ASSIGNED
Attached patch patch, complete (obsolete) — — Splinter Review 
Same as previous, but changes for *.h added
Attachment #203976 - Attachment is obsolete: true
Comment on attachment 204026 [details] [diff] [review]
patch, complete

review request
Attachment #204026 - Flags: review?(thesuckiestemail)
Comment on attachment 204026 [details] [diff] [review]
patch, complete

r=thesuckiestemail@yahoo.se
Please fix intendation though, header has two lines wrapped into one for instance.
(IMHO also remove some blank lines)

Can't really test it as my current tree calls into debugger a lot (every view creation and destruction) but it seems ok.
Attachment #204026 - Flags: review?(thesuckiestemail) → review+
Attached patch patch — — Splinter Review 
for Nielx/1.8* convinience - adjusted identation, in other aspects all exactly as in previous
Attachment #204026 - Attachment is obsolete: true
landed in trunk
Checking in mozilla/widget/src/beos/nsWindow.h;
/cvsroot/mozilla/widget/src/beos/nsWindow.h,v  <--  nsWindow.h
new revision: 1.47; previous revision: 1.46
done
Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.112; previous revision: 1.111
done 

Closing.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Requesting approval for landing on the MOZILLA_1_8_BRANCH. 

This is a BeOS-only change and does not affect other platforms.
Attachment #233001 - Flags: approval1.8.1?
Attachment #233001 - Flags: approval1.8.1? → approval1.8.1+
Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.91.4.22; previous revision: 1.91.4.21
done
Checking in mozilla/widget/src/beos/nsWindow.h;
/cvsroot/mozilla/widget/src/beos/nsWindow.h,v  <--  nsWindow.h
new revision: 1.35.4.13; previous revision: 1.35.4.12
done
Keywords: fixed1.8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: