315908 - Cannot change Alarm values for a task.

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Cecil Carpenter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051025 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051025 Firefox/1.5

After creating a task and exiting the dialog, if you edit the task later, you cannot change the Alarm values.

Reproducible: Always

Steps to Reproduce:
1. Create new task;
2. set Alarm type, time, and when;
3. select OK;
4. edit task;
5. Alarm is grayed out.

Actual Results:  
Could not change Alarm values.

Expected Results:  
Alarm values not grayed out and capable of being changed.

Comment 1

[Joey Minta]

What version of Sunbird/Calendar are you using?  If you haven't tried testing this in 0.3a1 yet, please do so.  0.2 and the Calendar extension are rather out-dated.

Comment 2

[Cecil Carpenter]

Sorry.  This is for 0.3a1.

Comment 3

[Stefan Sitter [:ssitter]]

Confirmed on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051110 Mozilla Sunbird/0.3a1+.

The following happens when I open the Edit Task dialog:

Case 1: Start Date and Alarm were set:
  Alarm values are correctly displayed but all fields are disabled
  and can not be changed. Error in JSC:
    Error: startPicker is not defined
    Source File: chrome://calendar/content/eventDialog.js
    Line: 283

Case 2: Due Date and Alarm were set:
  Alarm type shows "Not specified" and can be changed. The remaining Alarm 
  fields are disabled and can not be changed until Alarm type is set to popup
  or email.

Case 3: Start Date, Due Date and Alarm were set:
  Same as in case 1.

Nevertheless the alarm window shows pops up on the time set during task creation.

Comment 4

[Joey Minta]

Attachment: use proper variable

I think this fixes all of ssitter's cases.  I also suspect that this is the underlying cause of bug 315874 and bug 231611 comment #6.  Both those bugs should probably be closed if this is confirmed.

Comment 5

[Joey Minta]

Attachment: use proper variable and get correct element

One extra change from the previous version to fix ssitter's case 2.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 202689 [details] [diff] [review]
use proper variable and get correct element

r=mvl

Comment 7

[Joey Minta]

patch checked in