Closed Bug 315925 Opened 15 years ago Closed 15 years ago

Fix some TestUtf8 nits

Categories

(Core :: JavaScript Engine, defect, P4)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

There are some nits to pick in TestUtf8 in js.c. I have a patch.
Status: NEW → ASSIGNED
Priority: -- → P4
Target Milestone: --- → mozilla1.9alpha
Attached patch Fix the nitsSplinter Review
Attachment #202564 - Flags: review?(brendan)
Comment on attachment 202564 [details] [diff] [review]
Fix the nits

Hrm, now the switch case code is indented six spaces from the switch!

Fix that and put an empty line after the last declaration, and r=me.

Michael: prevailing style for switch does not treat case labels as statements worth a full indentation jump, so we use 2 and 2, to offset the case code 4 spaces from the switch and closing brace.

Also, we eschew space before ( in function calls and declarations.

/be
Attachment #202564 - Flags: review?(brendan) → review+
Checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
do we want this on spidermonkey 1.6?
mrbkap says yeah.
Blocks: js1.6rc1
Flags: testcase-
Flags: blocking1.8.1?
Not a blocker since we don't ship this code.
Flags: blocking1.8.1? → blocking1.8.1-
Comment on attachment 202564 [details] [diff] [review]
Fix the nits

... but feel free to check-in.
Attachment #202564 - Flags: approval1.8.1+
fixed1.8.1 by the JS 1.7 landing.
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.