Closed
Bug 315925
Opened 19 years ago
Closed 19 years ago
Fix some TestUtf8 nits
Categories
(Core :: JavaScript Engine, defect, P4)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
2.56 KB,
patch
|
brendan
:
review+
darin.moz
:
approval1.8.1+
|
Details | Diff | Splinter Review |
There are some nits to pick in TestUtf8 in js.c. I have a patch.
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P4
Target Milestone: --- → mozilla1.9alpha
|
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #202564 -
Flags: review?(brendan)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 202564 [details] [diff] [review]
Fix the nits
Hrm, now the switch case code is indented six spaces from the switch!
Fix that and put an empty line after the last declaration, and r=me.
Michael: prevailing style for switch does not treat case labels as statements worth a full indentation jump, so we use 2 and 2, to offset the case code 4 spaces from the switch and closing brace.
Also, we eschew space before ( in function calls and declarations.
/be
Attachment #202564 -
Flags: review?(brendan) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Comment 4•19 years ago
|
||
do we want this on spidermonkey 1.6?
|
|
||
Updated•19 years ago
|
Flags: testcase-
|
|
||
Updated•19 years ago
|
Flags: blocking1.8.1?
|
||
Comment 6•19 years ago
|
||
Not a blocker since we don't ship this code.
Flags: blocking1.8.1? → blocking1.8.1-
|
|
||
Comment 7•19 years ago
|
||
Comment on attachment 202564 [details] [diff] [review]
Fix the nits
... but feel free to check-in.
Attachment #202564 -
Flags: approval1.8.1+
You need to log in
before you can comment on or make changes to this bug.
Description
•