a11y: message/alert/help need to be dismissable with ESC key

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
12 years ago
a year ago

People

(Reporter: aaronr, Assigned: Doron Rosenberg (IBM))

Tracking

({fixed1.8.0.2, fixed1.8.1})

Trunk
x86
All
fixed1.8.0.2, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

1.93 KB, application/xhtml+xml
Details
814 bytes, patch
aaronr
: review+
smaug
: review+
Details | Diff | Splinter Review
(Reporter)

Description

12 years ago
as per http://www.mozilla.org/access/toolkit-checklist, we need to be able to dismiss message, alert and help popups with the ESC key.
(Reporter)

Comment 1

12 years ago
Created attachment 202705 [details]
testcase
(Assignee)

Comment 2

12 years ago
Created attachment 203035 [details] [diff] [review]
patch!

Adds a keypress listener to the generated XUL document.

Should we switch the code to use a real .xul file that sets itself up based on the passed in data?
Assignee: aaronr → doronr
Status: NEW → ASSIGNED
Attachment #203035 - Flags: review?(aaronr)

Comment 3

12 years ago
(In reply to comment #2)
> Should we switch the code to use a real .xul file that sets itself up based on
> the passed in data?

Yes we should, but we must be careful to not to allow messages to have chrome privileges.

(Reporter)

Comment 4

12 years ago
Comment on attachment 203035 [details] [diff] [review]
patch!

Until we have the XUL file, this patch will get us past the problem.
Attachment #203035 - Flags: review?(aaronr) → review+
(Assignee)

Updated

12 years ago
Attachment #203035 - Flags: review?(smaug)

Updated

12 years ago
Attachment #203035 - Flags: review?(smaug) → review+
(Assignee)

Comment 5

12 years ago
Checked into trunk
Whiteboard: xf-to-branch
(Reporter)

Comment 6

12 years ago
checked into MOZILLA_1_8_BRANCH via bug 323691.  Leaving open for now until it gets into 1.8.0

Updated

12 years ago
Whiteboard: xf-to-branch

Updated

12 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.0.2
Resolution: --- → FIXED
(Reporter)

Comment 7

11 years ago
verfied fixed on MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.