Closed Bug 316116 Opened 20 years ago Closed 19 years ago

Trademark Review for Gujarati (gu-IN) Firefox 1.5

Categories

(Mozilla Localizations :: gu-IN / Gujarati, defect)

Product:
Mozilla Localizations
Component:
gu-IN / Gujarati
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Assigned: ankit)

References

Details

Attachments

(4 files, 2 obsolete files)

Patch for localized browser/profile/bookmarks.html
31.37 KB, patch
Pike
: approval-l10n+
Details | Diff | Splinter Review
Zip file for localized browser/searchplugins
4.60 KB, application/zip
Details
Patch for localized browser/searchplugins/
13.27 KB, patch
Pike
: approval-l10n+
Details | Diff | Splinter Review
patch for list.txt
374 bytes, patch
Pike
: approval-l10n+
Details | Diff | Splinter Review
I guess the yahoo plugin could be the india one, right? Bookmarks are not localized at all, please look at http://wiki.mozilla.org/L10n:Firefox_Extras#Bookmarks for detailed instructions. Thank you and please attach a patch with your fixes and request approval-l10n.
I forgot to mention, please revert the format change to the bookmarks, too. This is seen in the beginnings and follows on thru the whole file, ==> en-GB/browser/profile/bookmarks.html <== <!DOCTYPE NETSCAPE-Bookmark-file-1> <!-- This is an automatically generated file. It will be read and overwritten. DO NOT EDIT! --> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8"> <TITLE>Bookmarks</TITLE> <H1>Bookmarks</H1> ==> gu-IN/browser/profile/bookmarks.html <== <!DOCTYPE NETSCAPE-Bookmark-file-1> <html><head> <!-- This is an automatically generated file. It will be read and overwritten. DO NOT EDIT! --> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <title>Bookmarks</title></head><body><h1>Bookmarks</h1>
patch for bookmarks.html which is now localized into Gujarati !
patch for bookmarks.html which is now localized into Gujarati !
Attachment #202962 - Attachment is obsolete: true
Attachment #202965 - Flags: approval-l10n+
Is there anything i need to do?
(In reply to comment #4) > Is there anything i need to do? > Err, yes. Check it in. Mention bug number, description, approval. Only check in stuff that got approval.
search plugins may want some love, too, see initial comment. Please attach a patch for that, request approval.
(In reply to comment #6) > search plugins may want some love, too, see initial comment. > Can you please help me where should i have to make changes for the searchplugins and what to change? > Please attach a patch for that, request approval. >
Patch for localized browser/searchplugins/yahoo.src ! Please suggest if anything is incorrect !
Please read http://wiki.mozilla.org/L10n:Firefox_Extras#Search_engine_plugins There is a reason why the german plugin is called yahoo-de for starters. And the changes are far from complete.
Pike, I have modified files inside the searchplugin folder as per documentation suggested by you. I have renamed them also. I can't be able to make patch of all. That's why attaching the .zip file of searchplugin folder. I will have to remove some of the files and some files need renaming operation. So, Please check it...
Attachment #204760 - Attachment is obsolete: true
ping
Patch for localized browser/searchplugins/
ping
Comment on attachment 206080 [details] [diff] [review] Patch for localized browser/searchplugins/ Waiting for approval. If anything needed please suggest.
Attachment #206080 - Flags: approval-l10n?
Attachment #206080 - Flags: approval-l10n? → approval-l10n+
Thanks for approval !
searchplugin.patch is approved. Now, do i have to commit these changes into the CVS?
Yes, please commit them to the MOZILLA_1_8_0_BRANCH as well as the MOZILLA_1_8_BRANCH and trunk.
Commited !
Comment on attachment 206080 [details] [diff] [review] Patch for localized browser/searchplugins/ >Index: list.txt >=================================================================== >RCS file: /l10n/l10n/gu-IN/browser/searchplugins/list.txt,v >retrieving revision 1.1 >diff -u -r1.1 list.txt >--- list.txt 6 May 2005 06:30:35 -0000 1.1 >+++ list.txt 16 Dec 2005 13:17:01 -0000 >@@ -1,6 +1,3 @@ >-google >-amazondotcom >-dictionary >-eBay >-yahoo >-creativecommons >\ No newline at end of file >+google-in >+eBay-in >+yahoo-in Oops, my bad, I should have caught this. The search engines are all named foo-gu, but you added foo-in to the list.txt file, the builds are busted. Please attach a patch to fix that and request approval-l10n on that, too.
I have updated list.txt with required changes! Please take a look at it and approve it!
Comment on attachment 210557 [details] [diff] [review] patch for list.txt approved, please land it on all three branches.
Attachment #210557 - Flags: approval-l10n+
Applied approved patch in CVS.
When i will get gujarati build on this page? Is there anything else i missed? http://www.mozilla.com/firefox/all
Component: Other → gu-IN / Gujarati
QA Contact: ankit644
FIXED, for quite some time now, too.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: