SeaMonkey.app still named 1.0a

RESOLVED FIXED

Status

SeaMonkey
General
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: stefanh, Assigned: Robert Kaiser)

Tracking

({fixed1.8})

Trunk
PowerPC
Mac OS X
fixed1.8
Bug Flags:
blocking-seamonkey1.0b +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
The SeaMonkey application bundle has it's version number set to 1.0a on mac. Some string have obviously not getting updated.

To see this, just right-click (or Ctrl-click) on the application icon and choose "Show Info".
/xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/InfoPlist.strings, line 4 -- CFBundleGetInfoString = "SeaMonkey 1.0a, Copyright © 1998-2005 Contributors to Mozilla.org.";
(Reporter)

Updated

12 years ago
Flags: blocking-seamonkey1.0b?
(Reporter)

Comment 2

12 years ago
BTW, someone have changed the encoding of the file. It should be utf-16, see http://developer.apple.com/documentation/MacOSX/Conceptual/BPInternational/Articles/StringsFiles.html
(Assignee)

Updated

12 years ago
Assignee: general → kairo
Flags: blocking-seamonkey1.0b? → blocking-seamonkey1.0b+
(Reporter)

Comment 3

12 years ago
We should probably remove line 4 in /xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/InfoPlist.strings and fix the encoding.

The above line in InfoPlist.strings overrides CFBundleGetInfoString in xpfe/bootstrap/macbuild/Contents/Info.plist.in, so keeping it will require that someone updates the file manually everytime the version number changes...

This will of course make the copyright in CFBundleGetInfoString non-localizable, but that's probably an issue we can live with (no one's translating it anyway, I guess). 

(Reporter)

Comment 4

12 years ago
Created attachment 202817 [details]
Altered file (utf-16)

This file should be good for both trunk and branch.
(Reporter)

Comment 5

12 years ago
Created attachment 202819 [details] [diff] [review]
Diff of InfoPlist.strings

Here's a diff illustrating the changes of the file in the previous attachment. smfr, can you rs this change to xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/InfoPlist.strings ?
Attachment #202819 - Flags: review?
(Reporter)

Updated

12 years ago
Attachment #202819 - Flags: review? → review?(sfraser_bugs)

Comment 6

12 years ago
Can't we just add that file to some list of files that need a version number update?
Attachment #202817 - Attachment mime type: application/octet-stream → text/plain; charset=UTF-16
Attachment #202817 - Attachment mime type: text/plain; charset=UTF-16 → text/plain; charset=UTF-16BE
(Reporter)

Comment 7

12 years ago
(In reply to comment #6)
> Can't we just add that file to some list of files that need a version number
> update?
> 
And then update the file manually? Yes, I suppose we could. Fwiw, Neither Firefox or Thunderbird has any "CFBundleGetInfoString" in their InfoPlist.strings. Camino has one, though. 

I'm fine with either way, as long as the file gets updated ;)
(Assignee)

Comment 8

12 years ago
(In reply to comment #6)
> Can't we just add that file to some list of files that need a version number
> update?

There is no such list, actually. Usually, there should be only one single file to change, and that is version.txt, which is used to set the env var MOZ_APP_VERSION at build time. Every other occurrence of the version number should be filled in from that var by some preprocessor (same with the product name BTW).

So the really correct way to deal with this would be to preprocess that file in some way (or remove the string if it's really not needed, like Stefan suggests).
fwiw there is a list (http://www.mozilla.org/build/release-checklist.html#version-numbers)
(Assignee)

Comment 10

12 years ago
(In reply to comment #6)
> Can't we just add that file to some list of files that need a version number
> update?

So you you're against removing this here and for haveing to update one more file for every version change, do I get that right? This is a Beta blocker, I really want to have something in on branch Very Soon Now (TM) to have this fixed there. We can discuss the stuff further (and maybe find a solution to do this The Right Way (TM)) regarding trunk, that's fine as long as we get it off the 1.0 radar...

Comment 11

12 years ago
Comment on attachment 202819 [details] [diff] [review]
Diff of InfoPlist.strings

I'm OK with this, it just might mean more work/mistakes later when people want to localize SM.
Attachment #202819 - Flags: review?(sfraser_bugs) → review+
(Assignee)

Comment 12

12 years ago
Comment on attachment 202819 [details] [diff] [review]
Diff of InfoPlist.strings

requesting 1.8 approval for mac-only, SeaMonkey-only change
Attachment #202819 - Flags: approval1.8.0.1?
(Assignee)

Comment 13

12 years ago
checked your UTF-16BE files into trunk, leaving open for branch checkin
(Assignee)

Updated

12 years ago
Attachment #202819 - Flags: approval1.8.0.1?
(Assignee)

Comment 14

12 years ago
checked into branch (cleared to land by mtschrep in email to
seamonkey-council).

As a side note, I looked into the cvs log for this file, and apparently Mozilla suite already had that problem once, and it was resolved the same way:

---------------
revision 1.4
date: 2003/02/27 23:33:45;  author: cltbld%netscape.com;  state: Exp;  lines: +2 -4
removed CFBundleGetInfoString = "Mozilla 1.3a, © 1998-2003 The Mozilla Organization"; per jj's instructions r=loan sr=jj
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.