316250 - crmftest doesn't build on OS/2

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Julien Pierre]

crmftest was recently added to cmd/manifest.mn, but crmftest doesn't build on OS/2 . The error is :

gmake.exe: *** No rule to make target `../../../../dist/OS22.45_gcc_DBG.OBJ/lib/
libcrmf.lib', needed by `OS22.45_gcc_DBG.OBJ/crmftest.exe'.  Stop.

This is because the Makefile doesn't make use of the LIB_PREFIX macro in the name. Instead, it has two cases - Windows without lib, and everything else with lib. This is an easy fix.

Comment 1

[Julien Pierre]

Attachment: use LIB_PREFIX

Comment 2

[Wan-Teh Chang]

Comment on attachment 202873 [details] [diff] [review]
use LIB_PREFIX

>-ifeq (,$(filter-out WIN%,$(OS_TARGET)))
>-EXTRA_LIBS += $(DIST)/lib/crmf.lib
>-else
>-EXTRA_LIBS += $(DIST)/lib/libcrmf.$(LIB_SUFFIX) 
>-endif
>+EXTRA_LIBS += $(DIST)/lib/$(LIB_PREFIX)crmf.lib

Need to use LIB_SUFFIX.  The line should read:

  EXTRA_LIBS += $(DIST)/lib/$(LIB_PREFIX)crmf.$(LIB_SUFFIX)

Comment 3

[Julien Pierre]

Attachment: Use LIB_PREFIX and LIB_SUFFIX

Oops, good catch, Wan-Teh. I modified the wrong line.
I checked in this patch that uses both LIB_PREFIX and LIB_SUFFIX.

/cvsroot/mozilla/security/nss/cmd/crmftest/Makefile,v  <--  Makefile
new revision: 1.7; previous revision: 1.6
done

Comment 4

[Julien Pierre]

Marking fixed.