Update sunbird icon to high quality

RESOLVED FIXED

Status

RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: robin.edrenius, Assigned: mostafah)

Tracking

Trunk
x86
Windows XP

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

13 years ago
Bundle an icon with better quality with Sunbird.
(Reporter)

Comment 1

13 years ago
Created attachment 202888 [details]
Higher quality icon.

This icon is of much better quality. (Taken from http://www.markcarson.com/MarkCarson/Asp/SunbirdIcons.asp)

mozilla/calendar/sunbird/app/Sunbird.ico should be replaced by this.
The downside of the attached icon is that it does not look good on Windows 2000. Reason: Windows 2000 does not support alpha channel. 
Also the attached icon seems to be only 32x32 size. (The current icon has 48x48, 32x32 and 16x16 size) Is there a reason not use the multi-resource version?
http://www.markcarson.com/images/icon/Sunbird-W2K.ico (without alpha-channel)
http://www.markcarson.com/images/icon/Sunbird-XP.ico  (with alpha-channel)
(Reporter)

Comment 3

13 years ago
(In reply to comment #2)
> The downside of the attached icon is that it does not look good on Windows
> 2000. Reason: Windows 2000 does not support alpha channel. 

Could you provide a screenshot to show how bad it would look?

> Also the attached icon seems to be only 32x32 size. (The current icon has
> 48x48, 32x32 and 16x16 size) Is there a reason not use the multi-resource
> version?
> http://www.markcarson.com/images/icon/Sunbird-W2K.ico (without alpha-channel)
> http://www.markcarson.com/images/icon/Sunbird-XP.ico  (with alpha-channel)
> 

The reason I attached this is that I've only tried building with that one.
I'll try the multi-resource and post back with the results when it's done.
(Reporter)

Comment 4

13 years ago
(In reply to comment #3)
> The reason I attached this is that I've only tried building with that one.
> I'll try the multi-resource and post back with the results when it's done.
>

Ok, I built with the multi-resource icon and I couldn't see any difference. I have no idea what we earn by doing that.

I guess we should use the win2k icon though, we don't want it to look bad for win2k users (I don't know how bad it would look in win2k with the other icon though, I don't have access to a win2k machine to try this.)
(Reporter)

Comment 5

13 years ago
Created attachment 203526 [details]
Multi-resource icon without alpha-channel

Attaching a high-quality multi-resource icon without alpha-channel
Attachment #202888 - Attachment is obsolete: true
Created attachment 203528 [details]
icons screenshot on win2k

Sorry Robin, did not saw your answer until now. Attached screenshot shows the two icons in Windows 2000.
(Reporter)

Comment 7

13 years ago
Created attachment 203531 [details]
Icon comparision on winXP

Here's the comparision on Windows XP, there's some difference, not very much though.
Mark:
Is it possible to create a multi-resource icon file for windows that contains both icon versions (with and without alpha-channel and maybe also the 256 Color version) in different sizes?
Created attachment 203705 [details]
multi-resource icon (W2K+XP)

This is the new icon Mark created. It contains
16x16 24x24 32x32 48x48 64x64         sized icons without alpha channel,
      24x24 32x32 48x48 64x64 128x128 sized icons with alpha channel.
On my Windows 2000 system it looks fine.

Robin: 
Could you please do a rebuild with this icon and comment how it looks on XP?
Attachment #203526 - Attachment is obsolete: true
(Reporter)

Comment 10

13 years ago
(In reply to comment #9)
> Robin: 
> Could you please do a rebuild with this icon and comment how it looks on XP?
> 

I've tried the new icon on XP and it looks great, that's the winner =)
Comment on attachment 203705 [details]
multi-resource icon (W2K+XP)

mvl, jminta or someone with cvs access: please check in this new icon to mozilla/calendar/sunbird/app/sunbird.ico
Attachment #203705 - Attachment filename: Sunbird.ico → sunbird.ico
Comment on attachment 203705 [details]
multi-resource icon (W2K+XP)

I build Sb successfully on Windows 2000 using the new icon.

Please perform check in to mozilla/calendar/sunbird/app/sunbird.ico
Attachment #203705 - Flags: first-review?(mvl)
Attachment #203705 - Flags: first-review?(mvl) → first-review+
patch checked in
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Because it's well hidden in the comments:

The icon was created by Mark Carson. So all tribute goes to him.

Thanks Mark, for giving us that eye candy!
You need to log in before you can comment on or make changes to this bug.