Open Bug 316340 Opened 19 years ago Updated 2 years ago

Flexible Space does not adjust to fit Bookmark Toolbar Items when placed on menubar

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Version:
2.0 Branch
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Status:
UNCONFIRMED

People

(Reporter: shoofy, Unassigned)

Details

Attachments

(1 file)

Screenshot showing the bug
193.53 KB, image/png
Details 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051113 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051113 Firefox/1.6a1

I have my bookmark toolbar items placed on the menubar (the toolbar with File, Edit, etc.). I have flexible space between Help and the bookmark toolbar items and between the bookmark toolbar items and the activity indicator. I have 3 bookmarks in the bookmark toolbar folder, so it should easily fit in that space and display all of them. The problem is that it only shows 2 bookmarks when maximized and 1 or 0 when its not maximized, even though there is still room for all 3. There are the little 2 arrows leading to a dropdown for the unshown items. It seems like the flexible space is only flexing to fit the default space alocated to the bookmark toolbar items when you do View>Toolbars>Customize and not to the actual bookmark toolbar folder contents. This bug does not exist in 1.5RC2.

Reproducible: Always

Steps to Reproduce:
1. View>Toolbars>Customize
2. Move bookmark toolbar items to menubar, between Help and activity indicator
3. Add flexible space on either side of the bookmark toolbar items

Actual Results:  
bookmark toolbar items are collapsed and only 2 or fewer are shown, along with a double arrow for a dropdown containing the rest of them

Expected Results:  
All bookmarks in folder, or at least as many as can fit when the flexible space ~=0, are displayed.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051113 Firefox/1.6a1 ID:2005111322

I see this: http://img374.imageshack.us/img374/9394/example3jv.png
Maybe an extension is causing this. Have you tried it in the safemode or with a new profile?
http://kb.mozillazine.org/Safe_Mode_(Firefox)
http://kb.mozillazine.org/Profile_Folder
Tried on a new profile, even with a different set of bookmarks, same result. I repeat though, this does not happen in 1.5RC2 or any of the other betas/release candidates even with the same profile, so it wasn't all that likely (although still possible) that it was an extension conflict.
Probably a related bug to this is that when a toolbar extension, such as Googlebar, extends longer than the window due to too many search terms, in older builds it would just collapse into a dropdown menu and be done with it. Now it still collapses, but it seems to stretch the window a little, so the scrollbars get pushed out of view, icons in the statusbar jump and some elements on webpages jump back and forth. Clearing the search terms invariably solves this. I'm sure you're going to tell me it's a Googlebar bug and it's not compatible with 1.6a1 anyway, but I honestly think that this is an FF bug that should be taken seriously.
By the way, my screen resolution is 1024 by 768. If yours is different that might be the reason that you can't confirm the bug.
Confirmed on 3.0a1! Although very slightly different: on the menu bar I have: menu, bookmarks, flex space, activity indicator. So, no flex space between the menu and the bookmarks.

I have so many bookmarks that it fills all the space and the flex space should "disappear", as it did in versions 1.0, 1,5 and 2.0. But in 3.0a1 it appears to consume the same amount of space as the bookmarks. That is very apparent when resizing the window.

In my particular case I can simply remove the flex space as a work-around, but I consider it a bug anyway.

The screen resolution does not matter: you can simply test that. You can even resize the window (when not maximized).
I have the same setup, two flexible spaces between Help and the activity indicator and the bookmarks toolbat inbetween.  In Firefox 2 this works perfectly fine.  In 3.0a2pre, I get a >> button that I need to click to get a dropdown showing my last four bookmarks.  Each flexible space is about as big as my bookmarks toolbar.  This also doesn't happen if I only have one flex space.

This is on a fresh start of Minefield run directly out of the folder (not the installer), with no extensions enabled.  (I didn't bother looking for updated version of my extensions.)
If you take out the flexible space to the right of the bookmarks it should work fine.  A similar issue I've noticed with Firefox 3.5 is that it adds a flexible space to the right of my bookmarks every time I start Firefox, which did not happen with previous versions.
This behavior of adding a flexible space to the right of my bookmarks continues in 3.5.1. This happens if you move the Bookmark Toolbar Items to the MenuBar. FF inserts a flexible space to the right of the bookmarks even if the bookmarks are not the right-most item on the MenuBar (say, if you use the activity indicator). If you take out the flexible space, it comes back when you restart FF. I only noticed this after 3.5. The flexible space becomes rather large, causing the same problem reported by users above. 

(In reply to comment #9)
>  A similar issue I've noticed with Firefox 3.5 is that it adds a flexible
> space to the right of my bookmarks every time I start Firefox, which did not
> happen with previous versions.
It's been a while since I've visited this bug, but I can confirm that this bug no longer affects me in the latest versions of Firefox.

As others have mentioned, the bookmarks toolbar item still has an intrinsic flexible space on its right, which is somewhat odd and counter-intuitive, but it's a different bug and it's easy to work around.  (Unless you want your bookmarks to be right-justified, I guess.)
(In reply to comment #11)
> As others have mentioned, the bookmarks toolbar item still has an intrinsic
> flexible space on its right, which is somewhat odd and counter-intuitive, but
> it's a different bug and it's easy to work around.  (Unless you want your
> bookmarks to be right-justified, I guess.)

And indeed I do want my bookmarks right-justified.  Thanks for explaining why that doesn't work.  Filed as bug 626153.
Version: unspecified → 2.0 Branch
Is this bug still relevant now?
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: