316412 - Camino build fails, gcc 4.0.1 (xcode 2.2)

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Mark Mentovai]

CompileC build/Camino.build/Deployment/CaminoStatic.build/Objects-normal/ppc/CertificatesWindowController.o/lizard/trunk/build/camino/camino/src/security/CertificatesWindowController.mm normal ppc objective-c++ com.apple.compilers.gcc.4_0
[...]
/lizard/trunk/build/camino/camino/src/security/CertificatesWindowController.mm:521:2: warning: #warning fix for plurals
../dist/include/pipnss/nsITokenPasswordDialogs.h:50: error: expected unqualified -id before 'template'

Comment 1

[Mark Mentovai]

Attachment: Move #include

Either do this or get rid of the "testing" stuff altogether.

Comment 2

[Mark Mentovai]

*** Bug 316411 has been marked as a duplicate of this bug. ***

Comment 3

[Simon Fraser [no longer active]]

That method is unused; we should just remove it.

Comment 4

[Mark Mentovai]

Attachment: Get rid of unused code

Comment 5

[Graeme Porteous]

Still broken for me with the following error,

/Users/graeme/dev/camino/darwin8.3.0/mozilla/camino/src/preferences/PreferenceManager.mm:82: error: expected initializer before '__builtin___CFStringMakeConstantString'
** BUILD FAILED **
make[4]: *** [libs] Error 1
make[3]: *** [libs_tier_99] Error 2
make[2]: *** [tier_99] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

Removing lines 78-84 in PreferenceManager.mm results in a successful build.

Comment 6

[Simon Fraser [no longer active]]

Comment on attachment 203011 [details] [diff] [review]
Get rid of unused code

You missed the header  :)

Comment 7

[Mark Mentovai]

Checked in with header fix.

I've also done something for comment 5.