Camino build fails, gcc 4.0.1 (xcode 2.2)

RESOLVED FIXED

Status

RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: mark, Assigned: mark)

Tracking

({fixed1.8})

Trunk
PowerPC
macOS
fixed1.8

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

14 years ago
CompileC build/Camino.build/Deployment/CaminoStatic.build/Objects-normal/ppc/CertificatesWindowController.o/lizard/trunk/build/camino/camino/src/security/CertificatesWindowController.mm normal ppc objective-c++ com.apple.compilers.gcc.4_0
[...]
/lizard/trunk/build/camino/camino/src/security/CertificatesWindowController.mm:521:2: warning: #warning fix for plurals
../dist/include/pipnss/nsITokenPasswordDialogs.h:50: error: expected unqualified -id before 'template'
(Assignee)

Comment 1

14 years ago
Posted patch Move #include (obsolete) — Splinter Review
Either do this or get rid of the "testing" stuff altogether.
Attachment #202997 - Flags: review?(sfraser_bugs)
(Assignee)

Comment 2

14 years ago
*** Bug 316411 has been marked as a duplicate of this bug. ***

Comment 3

14 years ago
That method is unused; we should just remove it.
(Assignee)

Comment 4

14 years ago
Attachment #202997 - Attachment is obsolete: true
Attachment #203011 - Flags: review?(sfraser_bugs)
Attachment #202997 - Flags: review?(sfraser_bugs)

Comment 5

14 years ago
Still broken for me with the following error,

/Users/graeme/dev/camino/darwin8.3.0/mozilla/camino/src/preferences/PreferenceManager.mm:82: error: expected initializer before '__builtin___CFStringMakeConstantString'
** BUILD FAILED **
make[4]: *** [libs] Error 1
make[3]: *** [libs_tier_99] Error 2
make[2]: *** [tier_99] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

Removing lines 78-84 in PreferenceManager.mm results in a successful build.

Comment 6

14 years ago
Comment on attachment 203011 [details] [diff] [review]
Get rid of unused code

You missed the header  :)
Attachment #203011 - Flags: review?(sfraser_bugs) → review-
(Assignee)

Comment 7

14 years ago
Checked in with header fix.

I've also done something for comment 5.
(Assignee)

Updated

14 years ago
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Assignee)

Updated

14 years ago
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.