316452 - Trademark Review for Mongolian (mn) Firefox 1.5

Status: RESOLVED FIXED

(Mozilla Localizations :: Other, defect)

Description

[Axel Hecht [:Pike]]

Please bring search engine plugins and bookmarks up-to-date, see the 
Branch tip of en-US as reference and see http://wiki.mozilla.org/L10n:Firefox_Extras on how to localize them.

Please attach a patch for these changes and request approval-l10n.

Thanks.

Comment 1

[Natsagdorj Shagdar]

Attachment: Updated bookmarks file

This is updated bookmarks file.

Comment 2

[Natsagdorj Shagdar]

Attachment: Updated dictionary.src file

This is updated dictionary.src file

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 203244 [details]
Updated bookmarks file

requesting approval works by '?', only me should grant approval with '+'

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 203244 [details]
Updated bookmarks file

I made some clarifications to http://wiki.mozilla.org/L10n:Firefox_Extras#Bookmarks,

this looks better, but central.html, store and start still need localized links, getfirefox should be removed.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 203245 [details]
Updated dictionary.src file

dictionary got removed (at least from list.txt), get rid of it.

http://lxr.mozilla.org/mozilla1.8/source/browser/locales/en-US/searchplugins
has the current state of the search engines, please make sure that you get the right ones.

Either that or request that I check-in-buddy for you, then I'd just copy them over and check them in.

Comment 6

[Natsagdorj Shagdar]

Attachment: Updated and corrected files and Start pages, Snippets

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 203353 [details]
Updated and corrected files and Start pages, Snippets 

startpages should be sent to startpages@, snippets to mlp-staff.
Stuff that is supposed to be added to the l10n frozen branch needs to come as patch, please.

Comment 8

[Natsagdorj Shagdar]

Attachment: patch file for answers.src

Comment 9

[Natsagdorj Shagdar]

Attachment: patch file for bookmarks.html

Comment 10

[Natsagdorj Shagdar]

Attachment: patch for list.txt file

Comment 11

[Natsagdorj Shagdar]

Attachment: patch for region.properties file

Comment 12

[Axel Hecht [:Pike]]

Comment on attachment 203368 [details] [diff] [review]
patch for region.properties file

mn.start.mozilla.com.

All the search engine related changes should be one patch, dictionary.com is supposed to be removed, not added. I don't see fixes for eBay.src, either, which is not up-to-date, AFAICT.

The bookmarks.html still  needs to do the "http://www.mozilla.org/" -> "http://www.mozilla.com/"

a- on these patches

Comment 13

[Natsagdorj Shagdar]

Attachment: bookmarks patch file

In the bookmarks.html file  "http://www.mozilla.org/" changed to  "http://www.mozilla.com/"

Comment 14

[Natsagdorj Shagdar]

Attachment: searchplugins

There are only google-mn and wikipedia-mn searchplugins. For now we do not have other popular search plugin's localized sites (eBay, yahoo etc). 
Do I need send the picture files as an attachment? (google-mn.gif and wikipedia-mn.png)

Comment 15

[Natsagdorj Shagdar]

Attachment: patch for region.properties

Comment 16

[Axel Hecht [:Pike]]

Comment on attachment 203397 [details] [diff] [review]
searchplugins 

please do a 
cvs -z3 diff -uN

I can't really tell what you're going to check in otherwise. Same for the other attachement.

And please unset your approval request and mark old patches as obsolete, thanks.

Comment 17

[Natsagdorj Shagdar]

(In reply to comment #16)
> (From update of attachment 203397 [details] [diff] [review] [edit])
> please do a 
> cvs -z3 diff -uN
> 
> I can't really tell what you're going to check in otherwise. Same for the other
> attachement.
> 
> And please unset your approval request and mark old patches as obsolete,
> thanks.
> 
I am so sorry if I am doing trouble for you. 
Please give me short instruction: 
In my browser/searchplugins directory, I added google-mn.src, google-mn.gif, wikipedia-mn.src and wikipedia-mn.png files. I removed other files because we don't have localized match.
So my question is, how should I make patch files for them? Should I send a result file of "cvs -z3 diff -uN > mydiff.diff" command? or should I just send my added files as an attachment?
thank you
Thank you

Comment 18

[Axel Hecht [:Pike]]

cvs add foo.src
for the src files you added, 
cvs add -kb foo.png
for the corresponding images,
cvs rm bar.src bar.png
for those plugins that you removed and
cvs diff -uN
will then include the added and removed files in the patch, without the images,
which is OK.

Comment 19

[Natsagdorj Shagdar]

Attachment: Please approve these changes in browser/searchplugins folder

Comment 20

[Natsagdorj Shagdar]

Attachment: changes in list.txt file

Comment 21

[Natsagdorj Shagdar]

Attachment: 2 spelling errors are fixed.

Comment 22

[Axel Hecht [:Pike]]

I see a whole bunch of check-ins in mn, but no approvals. 
I don't see any check-in comments either, Natsagdorj, could you please clarify?

Comment 23

[Natsagdorj Shagdar]

(In reply to comment #22)
> I see a whole bunch of check-ins in mn, but no approvals. 
> I don't see any check-in comments either, Natsagdorj, could you please clarify?
> 
I am so sorry. It was all my fault. Just before you wrote me a short instruction, I had wrong understanding 
of using bugzilla. It was my first time that I wanted to make a change in cvs and ask an approvement in bugzilla after a release lock down.
Everything that I made was wrong. ( localizors in irc.mozilla.org are explained me how do I properly make it).
I will do my best to that I will never do such a stupid mistake. :)

Could you tell me what should I do to correct my mistake?

Comment 24

[Axel Hecht [:Pike]]

region.properties should not reference yahoo, if we don't ship it.

Rafael, do you approve google-mn, wikipedia-mn for mongolian?

Comment 25

[Natsagdorj Shagdar]

(In reply to comment #24)
> region.properties should not reference yahoo, if we don't ship it.

Mongolian use yahoo very often, however, we do not have locale yahoo. I don't have other alternative search engine to "browser.search.order.2=" entry. 
Is that possible to leave it as yahoo? or it must be a localised one ?

 
> Rafael, do you approve google-mn, wikipedia-mn for mongolian?
> 

Comment 26

[Axel Hecht [:Pike]]

Comment on attachment 203700 [details] [diff] [review]
Please approve these changes in browser/searchplugins folder

This patch landed without approval and removed yahoo.src.

So, should mn have yahoo or not?

Comment 27

[Axel Hecht [:Pike]]

Comment on attachment 203701 [details] [diff] [review]
changes in list.txt file

already landed, non-approved.

Comment 28

[Axel Hecht [:Pike]]

Comment on attachment 203702 [details] [diff] [review]
2 spelling errors are fixed. 

already landed without approval

Comment 29

[Natsagdorj Shagdar]

(In reply to comment #26)
> (From update of attachment 203700 [details] [diff] [review] [edit])
> This patch landed without approval and removed yahoo.src.
> 
> So, should mn have yahoo or not?
> 

Is that possible to leave empty the "browser.search.order.2=" entry in the region.properties file? 
If so, MN should not have yahoo. If not, I need to add yahoo. 

Comment 30

[Axel Hecht [:Pike]]

You can just remove the line completely, compare-locales is clever enough for
that now.

Please attach a patch and request approval, do not check in before the patch
is approved.

Comment 31

[Natsagdorj Shagdar]

Attachment: Please approve this patch

Removed "browser.search.order.2=Yahoo" line completely

Comment 32

[Natsagdorj Shagdar]

landed on the branch

Comment 33

[Natsagdorj Shagdar]

Axel, it seems that I need attach a patch again adding a line "browser.search.order.2=" to region.properties file. Because compare-locale.pl gives an error that I need to add these line. 
What do you think?

Comment 34

[Natsagdorj Shagdar]

Attachment: region.properties patch for Mongolian(MN) [fixed 1.8]

added "browser.search.order.2=" line to the region.properties file, because compare-locale.pl gives an error.
Please approve this patch.

Comment 35

[Axel Hecht [:Pike]]

Comment on attachment 204772 [details] [diff] [review]
region.properties patch for Mongolian(MN) [fixed 1.8]

That's a build config problem, compare-locales is wrong here. It is fixed on the branch, but apparently that is not in the tagged tree for 1.5. I'll have a look.

Comment 36

[Axel Hecht [:Pike]]

Build is green now, as the build bug was fixed on the branches.