316638 - Sould not use obsoleted API(WINNLSEnableIME)

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We are using obsoleted API for IME disabling by bug 276727.
Masatoshi Kimura-san said, we can use ImmAssociateContext instead of WINNLSEnableIME.
I confirmed that. It's good way. We should replace this API.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0(created by Kimura-san)

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 203209 [details] [diff] [review]
Patch rv1.0(created by Kimura-san)

timeless:

Looks good for me.
Please check it too.

Comment 3

[timeless]

Comment on attachment 203209 [details] [diff] [review]
Patch rv1.0(created by Kimura-san)

>RCS file: /cvsroot/mozilla/widget/src/windows/nsWindow.cpp,v
>retrieving revision 3.594
>@@ -7353,37 +7351,30 @@ NS_IMETHODIMP nsWindow::GetIMEOpenState(
> NS_IMETHODIMP nsWindow::SetIMEEnabled(PRBool aState)
>+  if (aState && !mOldIMC)
>+    return NS_OK; // already enabled
>+  if (!aState && mOldIMC)
>+    return NS_OK; // already disabled

you could use == or ^ instead of these paired conditions:

if (!aState == mOldIMC)
  return NS_OK;

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #3)
> you could use == or ^ instead of these paired conditions:
> 
> if (!aState == mOldIMC)
>   return NS_OK;
> 

Is this right? I think:

if (!aState == !!mOldIMC)
  return NS_OK;

Comment 5

[Masatoshi Kimura [:emk]]

IMO that is bit tricky and unreadable. Actually, timeless made a mistake :-)

Comment 6

[[e-mail]]

Comment on attachment 203209 [details] [diff] [review]
Patch rv1.0(created by Kimura-san)

>+  if (aState && !mOldIMC)
>+    return NS_OK; // already enabled
>+  if (!aState && mOldIMC)
>+    return NS_OK; // already disabled
While I don't understand why enabling IME would give you an old IMC my vote for the test goes to if (!aState != !mOldIMC)

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Kimura-san:

Could you create new patch for check-in?

Comment 8

[Masatoshi Kimura [:emk]]

Attachment: Patch rv1.1

Incorporated neil's suggestion

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in. thank you for your work!