316672 - Trademark Review for ZH-TW

Status: RESOLVED FIXED

(Mozilla Localizations :: Other, defect)

Description

[Rafael Ebron (:rebron)]

1) Change search order /chrome/ browser-region/ region.properties
 a) browser.search.order.1=Yahoo
    browser.search.order.2=Google

2) Add yahoo search plug-in

Comment 1

[Rafael Ebron (:rebron)]

Attachment: yahoo plugin

Comment 2

[Rafael Ebron (:rebron)]

Attachment: image

Comment 3

[Axel Hecht [:Pike]]

(In reply to comment #0)
> 1) Change search order /chrome/ browser-region/ region.properties
>  a) browser.search.order.1=Yahoo
>     browser.search.order.2=Google

Sorry, didn't cross check that, the order string needs to match the name, thus

browser.search.order.1=Yahoo! Taiwan Search

Comment 4

[Rafael Ebron (:rebron)]

Actually what's preferred is if we change the name value to match region.properties.

<SEARCH
    	version = "7.1"
	name = "Yahoo"
	description = "Yahoo! Taiwan Search"

Also, search order should be:

browser.search.order.1=Yahoo
browser.search.order.2=Google
browser.search.order.3=Amazon 網路書店
browser.search.order.4=臺灣 eBay
browser.search.order.5=創意公共園地

Comment 5

[Hung-Te Lin]

(In reply to comment #4)
> browser.search.order.3=...
Adding order.3 order.4 order.5 makes fx builds in tinderbox orange.

Properties in ./chrome/browser-region/region.properties don't match:
  In /builds/tinderbox/Fx-Mozilla1.8-l10n/Linux_2.4.20-28.8_Clobber/mozilla/../l10n/zh-TW/browser: (remove these from your localization)
    browser.search.order.5
    browser.search.order.3
    browser.search.order.4

Is someone going to fix this or we're just leaving tinderbox orange?

Comment 6

[Axel Hecht [:Pike]]

(In reply to comment #5)
> Is someone going to fix this or we're just leaving tinderbox orange?

bug 316674 landed on the branch to fix this.

Comment 7

[Axel Hecht [:Pike]]

piaip, could you please make a patch to set startup.homepage_override_url in
http://lxr.mozilla.org/l10n-mozilla1.8/source/zh-TW/browser/chrome/browser-region/region.properties#14
back to the en-US value?
http://www.mozilla.org/products/firefox/releases/whatsnew/
For locales without an affiliate, we'd like to get that on the mozilla.org server.
Once we have that page done and you have a localization, please file a bug with
the translation attached, CC me, and we'll work on a server side solution to 
put that up depending on accept-locales or something.

Thanks.

Comment 8

[Hung-Te Lin]

Attachment: "What's New" link, in response to Pike's request in #7

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 203469 [details] [diff] [review]
"What's New" link, in response to Pike's request in #7

Thank you, please comment in the bug once this is checked in.

Comment 10

[Hung-Te Lin]

(In reply to comment #9)
> Thank you, please comment in the bug once this is checked in.
It's done, and thanks.

Comment 11

[Axel Hecht [:Pike]]

Piaip, are we done with search engines?

What slipped through the whole search engine discussion, we need some fixes for the bookmarks:

http://www.mozilla.com/products/firefox/central.html should point to 
http://www.mozilla-world.org/ko/products/firefox/start/central.html, and please
remove the korean product page link, and the store link should go to
http://store.mozilla-europe.org/ko.
As extensions are really security sensitive, please remove the link to the 
localized service. This is the same reasoning as with the homepage_override.
We want stuff like that on official servers.
The korean mzine is fine.

Thanks and sorry for the late notice, this fell between the chairs.

Comment 12

[Hung-Te Lin]

(In reply to comment #11)
> Piaip, are we done with search engines?
   haven't we?

> What slipped through the whole search engine discussion, we need some fixes for
> the bookmarks:
> http://www.mozilla.com/products/firefox/central.html should point to 
> http://www.mozilla-world.org/ko/products/firefox/start/central.html, and please
   I think this should be forwarded to Channy, not zh-TW.
   And yes, we already use zh for mozilla-world link.
   Another issue is, should we use zh-tw or zh-cn?

> remove the korean product page link, and the store link should go to
> http://store.mozilla-europe.org/ko.
   Should I link store to store.mozilla-world.org/zh ? or zh-TW? or mozilla-europe?
   Even if we don't have that page now?

> As extensions are really security sensitive, please remove the link to the 
> localized service. 
   Addons.mozilla.org? I have that left unchanged.

> The korean mzine is fine.
  Absolutely ko stuff, not related to me :)

Comment 13

[Axel Hecht [:Pike]]

(In reply to comment #12)
> (In reply to comment #11)
> > Piaip, are we done with search engines?
>    haven't we?

Ok, we have. And sorry about the bookmarks confusion, totally wrong bug. I don't think we want to fix the store link for 1.5, that's not really essential, we may want to do that for 1.5.1.

Waah.

Comment 14

[Rafael Ebron (:rebron)]

One more change.  Need homePageSingleStartURL to be

#expand
homePageSingleStartMainURL=http://zh-tw.start.mozilla.com/firefox?client=firefox-a&rls=__MOZ_DISTRIBUTION_ID_UNQUOTED__:__AB_CD__:official

This is in brand.properties

Comment 15

[Axel Hecht [:Pike]]

Attachment: use __AB_CD__, even

Comment 16

[Axel Hecht [:Pike]]

Comment on attachment 203943 [details] [diff] [review]
use __AB_CD__, even

in order to take this for the next round of builds, I'll check this in with self approval, sorry for the invasion.

Comment 17

[Axel Hecht [:Pike]]

stab, stab, stab, darn bug, stay closed!

/me crosses his fingers.