should enable IME on applet and embed elements

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
Internationalization
RESOLVED FIXED
12 years ago
8 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod, intl, regression})

Trunk
mozilla1.9alpha1
x86
Windows 2000
inputmethod, intl, regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 3 obsolete attachments)

This is regression of bug 55751.
We should enable IME if applet or embed element have focus.
Created attachment 203268 [details] [diff] [review]
Patch rv1.0
Attachment #203268 - Flags: superreview?(roc)
Attachment #203268 - Flags: review?(roc)
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
Created attachment 203277 [details] [diff] [review]
Patch rv1.1

Thank you, Kimura-san!
Attachment #203268 - Attachment is obsolete: true
Attachment #203277 - Flags: superreview?(roc)
Attachment #203277 - Flags: review?(roc)
Attachment #203268 - Flags: superreview?(roc)
Attachment #203268 - Flags: review?(roc)
Created attachment 203279 [details] [diff] [review]
Patch rv1.2

Sorry, there are some case that embed element creates box by CSS.
We need to check for embed element is loaded plug-in too.
Attachment #203277 - Attachment is obsolete: true
Attachment #203279 - Flags: superreview?(roc)
Attachment #203279 - Flags: review?(roc)
Attachment #203277 - Flags: superreview?(roc)
Attachment #203277 - Flags: review?(roc)
testcase1(object, embed, embed[wmode="opaque"]):
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2974&action=view
testcase2(alt content of applet):
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2977&action=view
testcase3(alt content of embed):
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2978&action=view
Attachment #203279 - Flags: superreview?(roc)
Attachment #203279 - Flags: superreview+
Attachment #203279 - Flags: review?(roc)
Attachment #203279 - Flags: review+
Created attachment 203335 [details] [diff] [review]
Patch for check-in
Attachment #203279 - Attachment is obsolete: true
checked-in.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
+  if (nsObjectLoadingContent::Type() == eType_Plugin)
+    return nsIContent::IME_STATUS_ENABLE;
+  return nsIContent::GetDesiredIMEState();

1) why not just Type(), like in IsFocusable()?
2) why not call the method of the direct superclass (nsGenericHTMLElement, if I recall correctly)?
1. If the method names are conflict by some inherited classes, is this better way?
2. Ah, this may be bad...
(In reply to comment #8)
> 1. If the method names are conflict by some inherited classes, is this better
> way?

Sorry, I don't understand what you mean... is there another class in this hierarchy that has a Type() method? In general, I would leave off the class name, to make the code easier to read.
(Assignee)

Updated

12 years ago
Depends on: 316867
O.K. I filed bug 316867.
thanks!
Keywords: inputmethod
You need to log in before you can comment on or make changes to this bug.