316715 - should enable IME on applet and embed elements

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

This is regression of bug 55751.
We should enable IME if applet or embed element have focus.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Attachment: Patch rv1.0

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Attachment: Patch rv1.1

Thank you, Kimura-san!

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Attachment: Patch rv1.2

Sorry, there are some case that embed element creates box by CSS.
We need to check for embed element is loaded plug-in too.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

testcase1(object, embed, embed[wmode="opaque"]):
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2974&action=view
testcase2(alt content of applet):
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2977&action=view
testcase3(alt content of embed):
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2978&action=view

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Attachment: Patch for check-in

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

checked-in.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

+  if (nsObjectLoadingContent::Type() == eType_Plugin)
+    return nsIContent::IME_STATUS_ENABLE;
+  return nsIContent::GetDesiredIMEState();

1) why not just Type(), like in IsFocusable()?
2) why not call the method of the direct superclass (nsGenericHTMLElement, if I recall correctly)?

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

1. If the method names are conflict by some inherited classes, is this better way?
2. Ah, this may be bad...

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #8)
> 1. If the method names are conflict by some inherited classes, is this better
> way?

Sorry, I don't understand what you mean... is there another class in this hierarchy that has a Type() method? In general, I would leave off the class name, to make the code easier to read.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

O.K. I filed bug 316867.

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

thanks!