316842 - nsMsgSearchNewsEx dead code

Status: VERIFIED FIXED

(MailNews Core :: Search, defect)

Description

[:Mook]

nsMsgSearchNewsEx is guarded by #ifdef EXNEWSSEARCH which is never defined.  Patch coming to remove that code.

Feel free to wontfix, I guess.  I'm just trying to kill dead code in hope of understanding mailnews one day :)

Comment 1

[:Mook]

Attachment: remove unused code

Please tell me if I'm at least going in the right direction - if I am, I'll go over the code a second time and add a follow-up to kill the dredd references (after confirming they do nothing).  Not sure if removal of dead code is actually desired, though I see no point of them existing :)

Comment 2

[David :Bienvenu]

Comment on attachment 203383 [details] [diff] [review]
remove unused code

seems good to me - I can land this...

Comment 3

[David :Bienvenu]

fix checked in, thx, mook.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

/mailnews/base/search/public/nsMsgSearchAdapter.h, line 201 -- #ifdef DOING_EXNEWSSEARCH
/mailnews/base/search/public/nsMsgSearchAdapter.h, line 217 -- #ifdef DOING_EXNEWSSEARCH
/mailnews/base/search/public/nsMsgSearchAdapter.h, line 237 -- #ifdef DOING_EXNEWSSEARCH

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/mailnews/base/search/src&command=DIFF_FRAMESET&file=nsMsgSearchAdapter.cpp&rev1=1.81&rev2=1.82&root=/cvsroot

David, it appears that you missed the header file code removal...

Comment 5

[David :Bienvenu]

oops, as StephenD points out, I forgot to check in the header file change. I've done so now.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

verified via lxr.