31693 - Crash on Send (Page) a 2nd time when 1st send delays/fails...

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P2)

Description

[laurel]

Using 2000-03-13-03-m15-nb1b commercial build on linux rh6.0

I was sending a web page which had some apparent Send problems, although I
didn't get any failed send alert or anything.  The compose window was still
around after first send.  I clicked Send again which resulted in a crash. I can
reproduce.

URL:  http://www.discovery.com/

1.  Browser window and mail window open. Mail open to IMAP account, already
authenticated.  Pref set for plain text compose window.
2.  In browser window, load the url referenced above, wait for it to finish
loading.
3.  From the browser window, File|Send Page. Address the message and click Send.
    Compose window is still around, no alert displays telling me about failed
send problems.
4.  Click Send in the compose window again.

Result:  crash occurs.

I submitted a talkback incident, can't get to talkback for report now.  Will
provide info later.

Comment 1

[laurel]

Attachment: Talkback report 6798055

Comment 2

[Phil Peterson]

Reassign to rhp, cc ducarroz

Comment 3

[laurel]

For more info on ways to reproduce:
I seem to also get delayed sending, a lingering compose window, when I have HTML
format conversion on and send an html message to a non-html savvy email address
-- i.e. I have formatting pref set to "convert to plain text" or "send both
plain text and html". 

Comment 4

[Phil Peterson]

Nominate for nsbeta2. At modem-speed, it takes 4-5 secs to send a message, so
it's easy to get suckered into clicking twice.

Comment 5

[Phil Peterson]

*** Bug 41291 has been marked as a duplicate of this bug. ***

Comment 6

[Phil Peterson]

transferring nsbeta+ from duplicate bug

Comment 7

[rhp (gone)]

I believe this was a bug that I just fixed with silent failures on send 
operations. That put us in a bad state and we would crash. It's all better now 
and we are much more tolerant on sending web pages full of images, etc... that 
we can't include in the MHTML mail itself.

- rhp

*** This bug has been marked as a duplicate of 35744 ***

Comment 8

[laurel]

I'm still able to get into a greatly delayed state when sending and crash occurs
when I click send again.  Same old thing. Reopening.

Talkback 12400178, but not a good incident report. We're having trouble with
linux talkback reports.

Comment 9

[laurel]

Was using 2000-06-13-08 m17 commercial build, followed my original steps.

Comment 10

[rhp (gone)]

Hi JF,
The real problem here is that the user can hit send multiple times on the UI. 
We should be disabling that button as soon as they hit it the first time.

- rhp

Comment 11

[Ben Bucksch (:BenB)]

> We should be disabling that button as soon as they hit it the first time.

Be carefull with this. 4.x disables the button (but lukily not the menu item),
but doesn't re-enable it, if I hit |stop|. Also, be sure to re-enable it in all
failure cases.

Comment 12

[Jean-Francois Ducarroz]

change priority to P2 as it's a crash

Comment 13

[laurel]

Send Page doesn't appear to be working in today's linux commercial build, but I
tried several times with attaching a web page from the message compose window
and couldn't reproduce a crash.

I was still able to click the send button several times and the compose window
did some weird display things, but there was no crash. 

Comment 14

[Jean-Francois Ducarroz]

FIxed and checked in. Ui button and menu are now disabled during the send or 
save process.

Comment 15

[laurel]

OK using jun22 commercial build, linux rh6.0 NT 4.0 and mac OS 9.0