Duplicate of/related to bug 299960?
*** This bug has been marked as a duplicate of 258080 ***
*** Bug 299960 has been marked as a duplicate of this bug. ***
Created attachment 203688 [details] Better self-explanatory basic testcase
Created attachment 203689 [details] Better self-explanatory basic testcase Sorry: previous attachment was a wrong filename selection.
Created attachment 273270 [details] [diff] [review] patch to implement rest of properties we compute Since tor landed the SVG properties yesterday, it wasn't that hard to implement the rest of the properties that we compute, and get the mochitests passing. So here's a patch to implement computed style for: -moz-force-broken-image-icon background-position content page-break-after page-break-before quotes I took a rather hacky approach for the counter() and counters() values inside content. They technically require us to implement another DOM interface, but I didn't bother. I stored CSS_COUNTER values like CSS_STRING, but made them not respond to getStringValue(). I also added CSS_ATTR support to nsROCSSPrimitiveValue (correctly, maybe). I fixed the bugs with page-break-before and page-break-after than this exposed (except for parsing 'avoid' but handling it like 'auto'.) In other words, we now let the 'auto' value override others at computation time, and we handle 'left' and 'right' like 'always' rather than 'auto', and we handle 'inherit' and '-moz-initial'. Hooray for r=alexsavulov. But I didn't fix quotes: -moz-initial, which was the other bug adding this turned up. The mochitests could use some further cleanup: the remaining properties in gNoComputedStyle shouldn't have it, but should be detectable in the computed style for other properties. And I left an empty gNoComputedValue array in test_value_storage.html to be cleaned up later.
Comment on attachment 273270 [details] [diff] [review] patch to implement rest of properties we compute >+nsComputedDOMStyle::GetContent(nsIDOMCSSValue** aValue) >+ str.Append(nsDependentString(a->Item(0).GetStringBufferValue())); I don't think you need the nsDependentString() here. With that, r+sr=bzbarsky. We could really use more code refactoring and consolidation in this file... Less codesize should be easy.
Fix checked in. How we do the codesize refactoring depends on whether we're going to remove support for getPropertyCSSValue, I suppose.