317060 - Missing dictionary in search bar for da locale

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Tim Riley [:timr]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; da; rv:1.8) Gecko/20051115 Firefox/1.5 

Missing wikipedia from the search bar in Danish locale on Windows.  
* I installed the latest nightly build.  
* Cleaned out my profile by deleting the Application Data/Mozilla directory.  
* Started Firefox-da.  
* Checked the search bar: it says: Google, Yahoo, Amazon Answers, Creative Commons, Ebay.  Missing Dictionary as expected in Axel's doc: https://intranet.mozilla.org/Trademark_L10n_Review#da

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Is dictionary really expected to be in all l10ns?

Comment 2

[Tim Riley [:timr]]

The proper list to use for verification has been very confusing.  Rafael confirmed that this is not a bug.

Comment 3

[Axel Hecht]

Apparently I got confused by my own script, it had a bug on the installed
search engines, and I didn't check that closely enough.

REOPENING for:

Remove dictionary, for real.
Fix icons for Google and Amazon.co.uk, both are broken on my windows install.

I did a clean install on pruned install dir and profile dir, no migration on 
profile creation, and dictionary shows up, and google icon is broken, amazon.co.uk
has no icon. Both are no binary on CVS. yahoo isn't binary as well, but looks ok.

Comment 4

[Axel Hecht [:Pike]]

I did a
cvs admin -kb amazon-en-GB.png google-dk.gif yahoo-dk.gif

dictionary.com still needs to be removed.

Comment 5

[Søren Munk Skrøder (extended hiatus)]

Axel : as in removing 
  browser/searchplugins/dictionary.png 
and 
  browser/searchplugins/dictionaty.src
plus 
  removing "dictionary" entry from list.txt
?? 

If so - can i do it without approval-cycle ? 

Comment 6

[Axel Hecht [:Pike]]

Yes, though just submitting a patch would have given you the same turnaround time,
and it's just a few clicks away.

Comment 7

[Søren Munk Skrøder (extended hiatus)]

done ;-)