317077 - Enable <canvas> support in Camino

Status: VERIFIED FIXED

(Camino Graveyard :: Page Layout, defect)

Description

[Simon Fraser [no longer active]]

For some reason <canvas> doesn't work in Camino; it works in FF 1.5 builds. I guess we just need to turn it on in the build. We should do this for 1.0.

Comment 1

[Simon Fraser [no longer active]]

Attachment: Add --enable-canvas

Comment 2

[Mark Mentovai]

Comment on attachment 203612 [details] [diff] [review]
Add --enable-canvas

I think this is incomplete.  Don't we need the typelib too?

While we're at it, let's also turn on svg.

Comment 3

[Simon Fraser [no longer active]]

Ah right :)

Do we really want SVG at this point? Is it ready go to?

Comment 4

[Mark Mentovai]

SVG isn't all the way there yet, but it's good enough for Fox 1.5.  http://www.mozilla.org/projects/svg/status-ff15.html.  I'm not sure how it stacks up feature-for-feature against the Adobe plug-in other than admissions of "we might suck, but they suck too," but I think it's really important to get the SVG DOM into the browser so scripts can get in on the action.

I've scheduled a canvas'n'svg build for tonight to see what impact it'll have on bloat.  And I've got a bug about turning mathml on too...

Comment 5

[Simon Fraser [no longer active]]

All yours then :)

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #4)
> I've scheduled a canvas'n'svg build for tonight to see what impact it'll have
> on bloat.

Mark, did this cause the 2005-11-18-10-1.0 build (which is really 1.0b1 with a new timestamp--and no canvas support at all, as far as I can tell via the demo and about:buildconfig)?

Comment 7

[Wevah (Nate Weaver)]

I doubt it, and it shouldn't have canvas support even if this did cause that; this looks to be just on trunk.

Comment 8

[Mark Mentovai]

This isn't done yet and hasn't landed anywhere.  111810 is just 1.0b1 and is the result of our monkeying around.

Comment 9

[Mark Mentovai]

Canvas and SVG together are worth about 250kB in the dmg.  (Typelibs and other support files were copied manually, I haven't done the pbproj yet.)

Comment 10

[Simon Fraser [no longer active]]

(In reply to comment #9)
> Canvas and SVG together are worth about 250kB in the dmg.  (Typelibs and other
> support files were copied manually, I haven't done the pbproj yet.)

Hm, that's non-trivial. I still wonder whether we want SVG.

Comment 11

[Mark Mentovai]

<canvas> alone is only worth 50kB.  I'll get some pbproj changes out soon, we need to link two extra libs and ship a typelib.

Comment 12

[Mark Mentovai]

Attachment: Enable <canvas> in Camino

The hand-crafted pbxproj changes add libmozcairo and libmozlibpixman to the final link during static builds.  In dynamic library builds, libgklayout already incorporates these two libraries, so no changes are needed.  For any build, the dom_canvas typelib is added to the "components" file copy phase.

Adding dom_canvas to embedding/config/basebrowser-mac-macho is harmless for other users of that embedding configuration because errors are ignored when setting up dist/Embed.

Comment 13

[Mark Mentovai]

Comment on attachment 203736 [details] [diff] [review]
Enable <canvas> in Camino

Removals from the mozconfig are to get rid of items that used to override defaults - the defaults have since changed.

Comment 14

[Mark Mentovai]

Branch'n'trunk

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Unless you have a really really REALLY good reason (like, "it doesn't work at all"), you should enable SVG in Camino. Otherwise you're creating a serious platform incompatibility and should not claim to be Gecko 1.8 or FF1.5 compatible.

Comment 16

[Samuel Sidler (old account; do not CC)]

SVG in Camino is now bug 317232.

Comment 17

[Samuel Sidler (old account; do not CC)]

v on branch and trunk.