Allow SM to download localized dictionary from MailNews start page

RESOLVED FIXED

Status

SeaMonkey
MailNews: Message Display
--
trivial
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Giacomo Magnini, Assigned: Giacomo Magnini)

Tracking

({fixed1.8})

Trunk
fixed1.8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

12 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it-IT; rv:1.7.12) Gecko/20050922 Fedora/1.0.7-1.1.fc4 Firefox/1.0.7
Build Identifier: 

Given the problems with redistribution of several localized dictionaries, provide a way of installing dictionaries licensed under a non compatible license (eg. GPL or LGPL only).


Reproducible: Always




Following on TB solution for this, add an empty identity to start.dtd and add it to start.xhtml: it will be empty (ie, not shown) for en-US, but can be localized for the other languages in some way.
Not sure if MT can deal with this, or localizers will have to manually edit the file, tho.
This is needed for having correct localizations, to avoid license problems and for parity with TB. ;)
(Assignee)

Comment 1

12 years ago
Created attachment 203627 [details] [diff] [review]
Easy patch, as explained
(Assignee)

Comment 2

12 years ago
This should be added (and adapted) by localizers to their langpack in start.dtd:

<!ENTITY extra.label '<script type="text/javascript">

<![CDATA[

function installDic(anchor)

{

   var params = {

       "Dictionary for xx-YY": {

           URL: anchor.getAttribute("href"),

           IconURL: "<url for install-spell.png>",

           toString: function() { return this.URL; }

       }

   }

   InstallTrigger.install(params);

}

]]>

</script>

<h2>Dictionaries</h2>

<p>To install the ZZZZZZ dictionary <a href="<url to localized spell.xpi file>" 

onclick="installDic(this);return false">click here</a>.</p><p>For additional information on dictionaries or for installing one in a different language 

<a 

href="<url for additional infos and/or additional dictionaries>">click here</a>.</p>

'>
(Assignee)

Comment 3

12 years ago
Last comment and I'll shut up: we probably will want this for 1.0...
Sorry for bug spam and for the overlong previous comment.

Comment 4

12 years ago
Comment on attachment 203627 [details] [diff] [review]
Easy patch, as explained

This solution seems plain wrong to me, as this is very unclear to localizers (i.e. almost all localizers won't do it correctly, as they don't know what to do), as well as complex XHTML code should not go into a L10n .dtd file, the relevant code should be added to the content/ file (start.xhtml in this case) - it's much too easy for localizers to make mistakes there. Additionally, there might be people who download en-US and want to have additional dictionaries, so it might make sense for them to have the link as well. The next point is that it's easy for localizers to ship the dictionaries in their XPI and localized builds themselves, as I do in the German packages. And above all, the L10n note in your patch is in wrong format.
Attachment #203627 - Flags: review-
(Assignee)

Comment 5

12 years ago
(In reply to comment #4)
The next point is that
> it's easy for localizers to ship the dictionaries in their XPI and localized
> builds themselves, as I do in the German packages.

While this is true (and I've done it myself until now), recent messages on the ng suggest (gerv?) that this may not be true anymore. For one, our dictionary can't be shipped in the LP for mozilla.org since the author has refused to relicense it, so it's strictly GPL/LGPL. This maybe true for most, if not all, of the dictionaries coming from OOo.

> And above all, the L10n note
> in your patch is in wrong format.

Didn't get this... It's a verbatim copy of TB equivalent.

Comment 6

12 years ago
(In reply to comment #5)
> While this is true (and I've done it myself until now), recent messages on the
> ng suggest (gerv?) that this may not be true anymore. For one, our dictionary
> can't be shipped in the LP for mozilla.org since the author has refused to
> relicense it, so it's strictly GPL/LGPL. This maybe true for most, if not all,
> of the dictionaries coming from OOo.

I think noone says that all contents of your XPI package need to be tri-license. For the L10n source in the mozilla.org code repository, this is different though, so it's right that we'll need to come to a good solution once we have our L10n source there as well, like TB does already.

> > And above all, the L10n note
> > in your patch is in wrong format.
> 
> Didn't get this... It's a verbatim copy of TB equivalent.

Well, then TB has a wrongly formatted L10n note there as well. I don't really wonder about crap code in their files ;-)
(Assignee)

Comment 7

12 years ago
Created attachment 203641 [details] [diff] [review]
Simplified approach
Attachment #203627 - Attachment is obsolete: true

Comment 8

12 years ago
This sounds better to me, at least as a first step - and it might even be doable for branch (as long as it goes in before Beta, which is planned to be feature and L10n freeze)...

I only would prefer if it would make clear what those dictionaries are for, so be sure to make up a text that somewhere mentions they are for the spell checker. Normal users might not know what dicitionaries in a mail program are for ;-)
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 9

12 years ago
Created attachment 203704 [details] [diff] [review]
Robert, is this better?
Attachment #203641 - Attachment is obsolete: true

Updated

12 years ago
Version: unspecified → Trunk
(Assignee)

Updated

12 years ago
Attachment #203704 - Flags: review?(iann_bugzilla)

Comment 10

12 years ago
Comment on attachment 203704 [details] [diff] [review]
Robert, is this better?

This is good as an intermediate fix for me, though it would be nice to have a more complete solution one day, at least for trunk.
BTW, it might be even better to use a text like "...other languages, go to dictionaries.mozdev.org" (with that host name linked), as "click here" link labels are not really good style...
Attachment #203704 - Flags: review+
(Assignee)

Comment 11

12 years ago
Created attachment 205053 [details] [diff] [review]
Implemented Kairo suggestion. Same as before for the rest.

Updated

12 years ago
Attachment #205053 - Flags: review+

Updated

12 years ago
Attachment #203704 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

12 years ago
Attachment #205053 - Flags: superreview?(neil.parkwaycc.co.uk)
(Assignee)

Updated

12 years ago
Attachment #203704 - Attachment is obsolete: true

Updated

12 years ago
Attachment #205053 - Flags: review+

Comment 12

12 years ago
Comment on attachment 205053 [details] [diff] [review]
Implemented Kairo suggestion. Same as before for the rest.

How about "Many additional languages may be _installed_ from the _dictionaries_ project at _mozdev_" (linked as appropriate)?

Comment 13

12 years ago
By the way, shouldn't someone ping the dictionaries project owner to tweak the instructions to mention SeaMonkey?
(Assignee)

Comment 14

12 years ago
Created attachment 205208 [details] [diff] [review]
What Neil asked.

Pinging project maintainer right now...
(Assignee)

Updated

12 years ago
Attachment #205208 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #205208 - Flags: review+
(Assignee)

Updated

12 years ago
Attachment #205053 - Attachment is obsolete: true
Attachment #205053 - Flags: superreview?(neil.parkwaycc.co.uk)
(Assignee)

Comment 15

12 years ago
Still no answer from the maintainer... Can someone else try to get in contact with him, too?

Comment 16

12 years ago
Comment on attachment 205208 [details] [diff] [review]
What Neil asked.

Looks like nobody is willing to admit to better English qualifications than my 'B' at O-level :-P
Attachment #205208 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

Updated

12 years ago
Assignee: mail → giacomo.magnini

Comment 17

12 years ago
Comment on attachment 205208 [details] [diff] [review]
What Neil asked.

Time is short here, but this is a safe fix that I believe we should take for beta. Not to mention that there's a string freeze soon... (3 days?)
Attachment #205208 - Flags: approval-seamonkey1.0?
Comment on attachment 205208 [details] [diff] [review]
What Neil asked.

first a=me

Comment 19

12 years ago
Comment on attachment 205208 [details] [diff] [review]
What Neil asked.

a=me, 2nd one :-)
Attachment #205208 - Flags: approval-seamonkey1.0? → approval-seamonkey1.0+

Comment 20

12 years ago
Checked in on trunk and 1.8 branch.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Keywords: fixed1.8

Comment 21

12 years ago
Checked in on MOZILLA_1_8_0_BRANCH.
You need to log in before you can comment on or make changes to this bug.